[PATCH] D132870: tweak zstd behavior in cmake and llvm config for better testing

[Cole Kissane via Phabricator via llvm-commits]

ckissane marked an inline comment as done.
ckissane added inline comments.


================
Comment at: llvm/cmake/modules/LLVMConfig.cmake.in:78
 if(LLVM_ENABLE_ZSTD)
-  set(zstd_ROOT @zstd_ROOT@)
+  set(zstd_DIR @zstd_DIR@)
   find_package(zstd)
----------------
ckissane wrote:
> phosek wrote:
> > I think it should be possible to omit this line altogether, this shouldn't be needed (zlib above is a special case).
> unfortunately this is the critical change
without this:
the builders that set custom zstd_DIR when building clang will build fine
but tests that run then using the llvmconfig vars will fail to find zstd


================
Comment at: llvm/lib/Support/CMakeLists.txt:24
 
+set(imported_libs "")
+
----------------
phosek wrote:
> This is unnecessary, you can just omit this line.
omitted


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132870/new/

https://reviews.llvm.org/D132870