[PATCH] D132870: tweak zstd behavior in cmake and llvm config for better testing

Cole Kissane via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 29 11:05:04 PDT 2022


ckissane added inline comments.


================
Comment at: llvm/cmake/modules/LLVMConfig.cmake.in:78
 if(LLVM_ENABLE_ZSTD)
-  set(zstd_ROOT @zstd_ROOT@)
+  set(zstd_DIR @zstd_DIR@)
   find_package(zstd)
----------------
phosek wrote:
> I think it should be possible to omit this line altogether, this shouldn't be needed (zlib above is a special case).
unfortunately this is the critical change


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132870/new/

https://reviews.llvm.org/D132870



More information about the llvm-commits mailing list