[PATCH] D132408: [SimplifyCFG] accumulate bonus insts cost

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/test/Transforms/SimplifyCFG/branch-fold-unrolled-loop.ll:3
+
+target triple = "amdgcn-amd-amdhsa"
+
----------------
Does the test depend on the target triple? If not , it should be removed. If it does it needs `REQUIRES:` to only run it when the AMDGPU backend is built.

Also, can you add the test in a separate patch and only include the changes caused by the patch in the diff so it is easier to see what's going on?

It also seems like the test coverage is quite limited. Are there some edge cases that should be covered by extra tests?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132408/new/

https://reviews.llvm.org/D132408