[PATCH] D132845: [MachO] Don't fold compact unwind entries with LSDA

[Vincent Lee via Phabricator via llvm-commits]

thevinster added a comment.

Some minor comments. Overall, LGTM, I'll leave it to people more familiar with the code to stamp.



================
Comment at: lld/MachO/UnwindInfoSection.cpp:466
            cuEntries[*foldBegin].encoding == cuEntries[*foldEnd].encoding &&
+           !cuEntries[*foldBegin].lsda && !cuEntries[*foldEnd].lsda &&
+           // If we've gotten to this point, we don't have an LSDA, which should
----------------
In what scenario would we have compact unwind entries //without// LSDA? I'm wondering if this is now effectively a condition that will never be hit and thus dead code now. 


================
Comment at: lld/test/MachO/compact-unwind-lsda-folding.s:2
+## Verify that the compact unwind entries for two functions with identical
+## unwind information and LSDA aren't folded together; see the comment in
+## UnwindInfoSectionImpl::finalize for why.
----------------
Should we also have a test for when they //can// be folded? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132845/new/

https://reviews.llvm.org/D132845