[PATCH] D132776: [mlir][MemRef] Canonicalize reinterpret_cast(extract_strided_metadata)

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet marked an inline comment as done.
qcolombet added inline comments.


================
Comment at: mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp:1622
+      return failure();
+    for (auto it :
+         llvm::zip(extractStridedMetadata.getStrides(), op.getStrides())) {
----------------
nicolasvasilache wrote:
> We're now allowed to use C++17 auto, something like this should work here and below.
> ```
> for (auto [extractStride, reinterpretStride] : llvm::zip(extractStridedMetadata.getStrides(), op.getStrides()))))
>   if (extractStride != reinterpretStride)
>     return failure();
> ```
Nice!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132776/new/

https://reviews.llvm.org/D132776