[PATCH] D132776: [mlir][MemRef] Canonicalize reinterpret_cast(extract_strided_metadata)

Nicolas Vasilache via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 29 04:43:57 PDT 2022


nicolasvasilache accepted this revision.
nicolasvasilache added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp:1622
+      return failure();
+    for (auto it :
+         llvm::zip(extractStridedMetadata.getStrides(), op.getStrides())) {
----------------
We're now allowed to use C++17 auto, something like this should work here and below.
```
for (auto [extractStride, reinterpretStride] : llvm::zip(extractStridedMetadata.getStrides(), op.getStrides()))))
  if (extractStride != reinterpretStride)
    return failure();
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132776/new/

https://reviews.llvm.org/D132776



More information about the llvm-commits mailing list