[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

Sebastian Neubauer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 25 03:16:15 PDT 2022


sebastian-ne added a comment.

This is probably caused by using `CMAKE_CFG_INTDIR` (indirectly) in more places. Seems like it expands to `$(Configuration)` for Visual Studio.
Searching more about it, it’s only set at build time, but not at install time, which is a problem as well.
On top of all, `CMAKE_CFG_INTDIR` is deprecated and superseded by generator expression: https://cmake.org/cmake/help/latest/variable/CMAKE_CFG_INTDIR.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132316/new/

https://reviews.llvm.org/D132316



More information about the llvm-commits mailing list