[PATCH] D126054: [InstCombine] Precommit test for D125750.

[Jianjian Guan via Phabricator via llvm-commits]

jacquesguan added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/extractelement.ll:4-5
+; RUN: opt < %s -passes=instcombine -S -data-layout="E-n64" | FileCheck %s --check-prefixes=ANY,ANY64,BE64
+; RUN: opt < %s -passes=instcombine -S -data-layout="e-n128" | FileCheck %s --check-prefixes=ANY,ANY128,LE128
+; RUN: opt < %s -passes=instcombine -S -data-layout="E-n128" | FileCheck %s --check-prefixes=ANY,ANY128,BE128
 
----------------
spatel wrote:
> jacquesguan wrote:
> > spatel wrote:
> > > In most of these tests, LE64 will be the same as LE128, and BE64 will be the same as BE128. Can we make common prefixes for those 2 pairs of runs?
> > Done, thanks.
> This is not what I was thinking. Would it make it the diff smaller like this:
> 
> ```
> ; RUN: opt < %s -passes=instcombine -S -data-layout="e-n64" | FileCheck %s --check-prefixes=ANY,ANYLE,LE64
> ; RUN: opt < %s -passes=instcombine -S -data-layout="e-n128" | FileCheck %s --check-prefixes=ANY,ANYLE,LE128
> ; RUN: opt < %s -passes=instcombine -S -data-layout="E-n64" | FileCheck %s --check-prefixes=ANY,ANYBE,BE64
> ; RUN: opt < %s -passes=instcombine -S -data-layout="E-n128" | FileCheck %s --check-prefixes=ANY,ANYBE,BE128
> ```
Done, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126054/new/

https://reviews.llvm.org/D126054