[PATCH] D132738: [PowerPC] CTRLoop pseudo instructions should not be duplicated

[ChenZheng via Phabricator via llvm-commits]

shchenz added a comment.

> Attached test case will be added before and removed by this fix.

Do you mean you plan to remove the test case? I think the test case should still be kept and check that a ctr-loop is generated after this fix.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:576
 }
-let hasSideEffects = 1, Defs = [CTR8] in {
+let hasSideEffects = 1, isNotDuplicable = 1, Defs = [CTR8] in {
 let Pattern = [(int_set_loop_iterations i64:$rS)] in
----------------
Maybe we can add some comments for this change, like `MTCTR8loop` must be inside a loop-preheader, duplicating the loop-preheader block will break this assumption?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132738/new/

https://reviews.llvm.org/D132738