[PATCH] D132813: [Support] Simplify isInt and isUInt with constexpr if (NFC)

Thorsten via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 28 12:24:23 PDT 2022


tschuett added inline comments.


================
Comment at: llvm/include/llvm/Support/MathExtras.h:369
+    return -(INT64_C(1) << (N - 1)) <= x && x < (INT64_C(1) << (N - 1));
+  (void)x; // MSVC v19.25 warns that x is unused.
+  return true;
----------------
You can use `[[maybe_unused]]` instead if you like.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132813/new/

https://reviews.llvm.org/D132813



More information about the llvm-commits mailing list