[lld] f0c0094 - [MachO] Remove stale comments

Shoaib Meenai via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 28 12:11:00 PDT 2022


Author: Shoaib Meenai
Date: 2022-08-29T00:10:33+05:00
New Revision: f0c00942a520c9944759b1334557b876ba7def9f

URL: https://github.com/llvm/llvm-project/commit/f0c00942a520c9944759b1334557b876ba7def9f
DIFF: https://github.com/llvm/llvm-project/commit/f0c00942a520c9944759b1334557b876ba7def9f.diff

LOG: [MachO] Remove stale comments

https://reviews.llvm.org/D93267 implemented handling more than 127
compact unwind encodings, and https://reviews.llvm.org/D123435 and
https://reviews.llvm.org/D124561 implemented stripping redundant
__eh_frame entries.

Added: 
    

Modified: 
    lld/MachO/UnwindInfoSection.cpp

Removed: 
    


################################################################################
diff  --git a/lld/MachO/UnwindInfoSection.cpp b/lld/MachO/UnwindInfoSection.cpp
index c3f563d5572b5..435c824a1e5d9 100644
--- a/lld/MachO/UnwindInfoSection.cpp
+++ b/lld/MachO/UnwindInfoSection.cpp
@@ -82,18 +82,10 @@ using namespace lld::macho;
 // advantage, achieving a 3-order-of-magnitude reduction in the
 // number of entries.
 //
-// * The __TEXT,__unwind_info format can accommodate up to 127 unique
-// encodings for the space-efficient compressed format. In practice,
-// fewer than a dozen unique encodings are used by C++ programs of
-// all sizes. Therefore, we don't even bother implementing the regular
-// non-compressed format. Time will tell if anyone in the field ever
-// overflows the 127-encodings limit.
-//
 // Refer to the definition of unwind_info_section_header in
 // compact_unwind_encoding.h for an overview of the format we are encoding
 // here.
 
-// TODO(gkm): prune __eh_frame entries superseded by __unwind_info, PR50410
 // TODO(gkm): how do we align the 2nd-level pages?
 
 // The offsets of various fields in the on-disk representation of each compact


        


More information about the llvm-commits mailing list