[PATCH] D132741: [DebugInfo] Fix line number attribution in mldst-motion

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 28 01:54:29 PDT 2022


djtodoro accepted this revision.
djtodoro added a comment.
This revision is now accepted and ready to land.

lgtm, thanks



================
Comment at: llvm/test/DebugInfo/Generic/mldst-motion-dbg.ll:25
+
+define dso_local void @_Z3funPii(i32* nocapture noundef writeonly %a, i32 noundef %cond) local_unnamed_addr #0 !dbg !7 {
+entry:
----------------
Nit: could drop `dso_local` and `local_unnamed_addr #0`


================
Comment at: llvm/test/DebugInfo/Generic/mldst-motion-dbg.ll:73-76
+!21 = !{!22, !22, i64 0}
+!22 = !{!"int", !23, i64 0}
+!23 = !{!"omnipotent char", !24, i64 0}
+!24 = !{!"Simple C++ TBAA"}
----------------
No need for `tbaa`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132741/new/

https://reviews.llvm.org/D132741



More information about the llvm-commits mailing list