[llvm] 56ea4f9 - [Transforms] Qualify auto in range-based for loops (NFC)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Sat Aug 27 21:21:31 PDT 2022
Author: Kazu Hirata
Date: 2022-08-27T21:21:02-07:00
New Revision: 56ea4f9bd3d6c44f95f9b7b8639c9db043448742
URL: https://github.com/llvm/llvm-project/commit/56ea4f9bd3d6c44f95f9b7b8639c9db043448742
DIFF: https://github.com/llvm/llvm-project/commit/56ea4f9bd3d6c44f95f9b7b8639c9db043448742.diff
LOG: [Transforms] Qualify auto in range-based for loops (NFC)
Identified with readability-qualified-auto.
Added:
Modified:
llvm/lib/Transforms/Coroutines/CoroFrame.cpp
llvm/lib/Transforms/Coroutines/CoroSplit.cpp
llvm/lib/Transforms/Coroutines/Coroutines.cpp
llvm/lib/Transforms/IPO/BlockExtractor.cpp
llvm/lib/Transforms/IPO/CrossDSOCFI.cpp
llvm/lib/Transforms/IPO/GlobalDCE.cpp
llvm/lib/Transforms/IPO/LowerTypeTests.cpp
llvm/lib/Transforms/IPO/SampleProfile.cpp
llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp
llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp
llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp
llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp
llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
llvm/lib/Transforms/Utils/CodeLayout.cpp
llvm/lib/Transforms/Utils/FixIrreducible.cpp
llvm/lib/Transforms/Utils/LCSSA.cpp
llvm/lib/Transforms/Utils/Local.cpp
llvm/lib/Transforms/Utils/LoopSimplify.cpp
llvm/lib/Transforms/Utils/LowerGlobalDtors.cpp
llvm/lib/Transforms/Utils/LowerMemIntrinsics.cpp
llvm/lib/Transforms/Utils/PredicateInfo.cpp
llvm/lib/Transforms/Utils/SampleProfileInference.cpp
llvm/lib/Transforms/Utils/SimplifyCFG.cpp
llvm/lib/Transforms/Utils/UnifyLoopExits.cpp
llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp
llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
llvm/lib/Transforms/Vectorize/VPlanSLP.cpp
llvm/lib/Transforms/Vectorize/VectorCombine.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Transforms/Coroutines/CoroFrame.cpp b/llvm/lib/Transforms/Coroutines/CoroFrame.cpp
index f7146a04e2084..6147260cdd0e9 100644
--- a/llvm/lib/Transforms/Coroutines/CoroFrame.cpp
+++ b/llvm/lib/Transforms/Coroutines/CoroFrame.cpp
@@ -629,8 +629,8 @@ void FrameTypeBuilder::addFieldForAllocas(const Function &F,
// patterns since it just prevend putting the allocas to live in the same
// slot.
DenseMap<SwitchInst *, BasicBlock *> DefaultSuspendDest;
- for (auto CoroSuspendInst : Shape.CoroSuspends) {
- for (auto U : CoroSuspendInst->users()) {
+ for (auto *CoroSuspendInst : Shape.CoroSuspends) {
+ for (auto *U : CoroSuspendInst->users()) {
if (auto *ConstSWI = dyn_cast<SwitchInst>(U)) {
auto *SWI = const_cast<SwitchInst *>(ConstSWI);
DefaultSuspendDest[SWI] = SWI->getDefaultDest();
@@ -2106,7 +2106,7 @@ static bool isSuspendReachableFrom(BasicBlock *From,
return true;
// Recurse on the successors.
- for (auto Succ : successors(From)) {
+ for (auto *Succ : successors(From)) {
if (isSuspendReachableFrom(Succ, VisitedOrFreeBBs))
return true;
}
@@ -2120,7 +2120,7 @@ static bool isLocalAlloca(CoroAllocaAllocInst *AI) {
// Seed the visited set with all the basic blocks containing a free
// so that we won't pass them up.
VisitedBlocksSet VisitedOrFreeBBs;
- for (auto User : AI->users()) {
+ for (auto *User : AI->users()) {
if (auto FI = dyn_cast<CoroAllocaFreeInst>(User))
VisitedOrFreeBBs.insert(FI->getParent());
}
@@ -2140,7 +2140,7 @@ static bool willLeaveFunctionImmediatelyAfter(BasicBlock *BB,
if (isSuspendBlock(BB)) return true;
// Recurse into the successors.
- for (auto Succ : successors(BB)) {
+ for (auto *Succ : successors(BB)) {
if (!willLeaveFunctionImmediatelyAfter(Succ, depth - 1))
return false;
}
@@ -2153,7 +2153,7 @@ static bool localAllocaNeedsStackSave(CoroAllocaAllocInst *AI) {
// Look for a free that isn't sufficiently obviously followed by
// either a suspend or a termination, i.e. something that will leave
// the coro resumption frame.
- for (auto U : AI->users()) {
+ for (auto *U : AI->users()) {
auto FI = dyn_cast<CoroAllocaFreeInst>(U);
if (!FI) continue;
@@ -2169,7 +2169,7 @@ static bool localAllocaNeedsStackSave(CoroAllocaAllocInst *AI) {
/// instruction.
static void lowerLocalAllocas(ArrayRef<CoroAllocaAllocInst*> LocalAllocas,
SmallVectorImpl<Instruction*> &DeadInsts) {
- for (auto AI : LocalAllocas) {
+ for (auto *AI : LocalAllocas) {
auto M = AI->getModule();
IRBuilder<> Builder(AI);
@@ -2184,7 +2184,7 @@ static void lowerLocalAllocas(ArrayRef<CoroAllocaAllocInst*> LocalAllocas,
auto Alloca = Builder.CreateAlloca(Builder.getInt8Ty(), AI->getSize());
Alloca->setAlignment(AI->getAlignment());
- for (auto U : AI->users()) {
+ for (auto *U : AI->users()) {
// Replace gets with the allocation.
if (isa<CoroAllocaGetInst>(U)) {
U->replaceAllUsesWith(Alloca);
@@ -2347,12 +2347,12 @@ static void eliminateSwiftErrorArgument(Function &F, Argument &Arg,
Builder.CreateStore(InitialValue, Alloca);
// Find all the suspends in the function and save and restore around them.
- for (auto Suspend : Shape.CoroSuspends) {
+ for (auto *Suspend : Shape.CoroSuspends) {
(void) emitSetAndGetSwiftErrorValueAround(Suspend, Alloca, Shape);
}
// Find all the coro.ends in the function and restore the error value.
- for (auto End : Shape.CoroEnds) {
+ for (auto *End : Shape.CoroEnds) {
Builder.SetInsertPoint(End);
auto FinalValue = Builder.CreateLoad(ValueTy, Alloca);
(void) emitSetSwiftErrorValue(Builder, FinalValue, Shape);
@@ -2820,6 +2820,6 @@ void coro::buildCoroutineFrame(Function &F, Shape &Shape) {
insertSpills(FrameData, Shape);
lowerLocalAllocas(LocalAllocas, DeadInstructions);
- for (auto I : DeadInstructions)
+ for (auto *I : DeadInstructions)
I->eraseFromParent();
}
diff --git a/llvm/lib/Transforms/Coroutines/CoroSplit.cpp b/llvm/lib/Transforms/Coroutines/CoroSplit.cpp
index 8c4d197a28998..b54ece4ad1cdf 100644
--- a/llvm/lib/Transforms/Coroutines/CoroSplit.cpp
+++ b/llvm/lib/Transforms/Coroutines/CoroSplit.cpp
@@ -1661,7 +1661,7 @@ static void coerceArguments(IRBuilder<> &Builder, FunctionType *FnTy,
ArrayRef<Value *> FnArgs,
SmallVectorImpl<Value *> &CallArgs) {
size_t ArgIdx = 0;
- for (auto paramTy : FnTy->params()) {
+ for (auto *paramTy : FnTy->params()) {
assert(ArgIdx < FnArgs.size());
if (paramTy != FnArgs[ArgIdx]->getType())
CallArgs.push_back(
@@ -1870,7 +1870,7 @@ static void splitRetconCoroutine(Function &F, coro::Shape &Shape,
Shape.CoroSuspends.size()));
// Next, all the directly-yielded values.
- for (auto ResultTy : Shape.getRetconResultTypes())
+ for (auto *ResultTy : Shape.getRetconResultTypes())
ReturnPHIs.push_back(Builder.CreatePHI(ResultTy,
Shape.CoroSuspends.size()));
@@ -1995,7 +1995,7 @@ static coro::Shape splitCoroutine(Function &F,
/// Remove calls to llvm.coro.end in the original function.
static void removeCoroEnds(const coro::Shape &Shape) {
- for (auto End : Shape.CoroEnds) {
+ for (auto *End : Shape.CoroEnds) {
replaceCoroEnd(End, Shape, Shape.FramePtr, /*in resume*/ false, nullptr);
}
}
diff --git a/llvm/lib/Transforms/Coroutines/Coroutines.cpp b/llvm/lib/Transforms/Coroutines/Coroutines.cpp
index ca723a724a5f8..ce4262e593b6e 100644
--- a/llvm/lib/Transforms/Coroutines/Coroutines.cpp
+++ b/llvm/lib/Transforms/Coroutines/Coroutines.cpp
@@ -300,7 +300,7 @@ void coro::Shape::buildFrom(Function &F) {
this->SwitchLowering.PromiseAlloca = SwitchId->getPromise();
this->SwitchLowering.ResumeEntryBlock = nullptr;
- for (auto AnySuspend : CoroSuspends) {
+ for (auto *AnySuspend : CoroSuspends) {
auto Suspend = dyn_cast<CoroSuspendInst>(AnySuspend);
if (!Suspend) {
#ifndef NDEBUG
@@ -346,7 +346,7 @@ void coro::Shape::buildFrom(Function &F) {
auto ResultTys = getRetconResultTypes();
auto ResumeTys = getRetconResumeTypes();
- for (auto AnySuspend : CoroSuspends) {
+ for (auto *AnySuspend : CoroSuspends) {
auto Suspend = dyn_cast<CoroSuspendRetconInst>(AnySuspend);
if (!Suspend) {
#ifndef NDEBUG
diff --git a/llvm/lib/Transforms/IPO/BlockExtractor.cpp b/llvm/lib/Transforms/IPO/BlockExtractor.cpp
index 9e27ae49a9012..dfadfdd736a72 100644
--- a/llvm/lib/Transforms/IPO/BlockExtractor.cpp
+++ b/llvm/lib/Transforms/IPO/BlockExtractor.cpp
@@ -161,7 +161,7 @@ void BlockExtractor::splitLandingPadPreds(Function &F) {
// Look through the landing pad's predecessors. If one of them ends in an
// 'invoke', then we want to split the landing pad.
bool Split = false;
- for (auto PredBB : predecessors(LPad)) {
+ for (auto *PredBB : predecessors(LPad)) {
if (PredBB->isLandingPad() && PredBB != Parent &&
isa<InvokeInst>(Parent->getTerminator())) {
Split = true;
diff --git a/llvm/lib/Transforms/IPO/CrossDSOCFI.cpp b/llvm/lib/Transforms/IPO/CrossDSOCFI.cpp
index dfe33ac9da0d2..4fe7bb6c757c5 100644
--- a/llvm/lib/Transforms/IPO/CrossDSOCFI.cpp
+++ b/llvm/lib/Transforms/IPO/CrossDSOCFI.cpp
@@ -87,7 +87,7 @@ void CrossDSOCFI::buildCFICheck(Module &M) {
NamedMDNode *CfiFunctionsMD = M.getNamedMetadata("cfi.functions");
if (CfiFunctionsMD) {
- for (auto Func : CfiFunctionsMD->operands()) {
+ for (auto *Func : CfiFunctionsMD->operands()) {
assert(Func->getNumOperands() >= 2);
for (unsigned I = 2; I < Func->getNumOperands(); ++I)
if (ConstantInt *TypeId =
diff --git a/llvm/lib/Transforms/IPO/GlobalDCE.cpp b/llvm/lib/Transforms/IPO/GlobalDCE.cpp
index f66b872e937d6..2f2bb174a8c87 100644
--- a/llvm/lib/Transforms/IPO/GlobalDCE.cpp
+++ b/llvm/lib/Transforms/IPO/GlobalDCE.cpp
@@ -240,7 +240,7 @@ void GlobalDCEPass::ScanTypeCheckedLoadIntrinsics(Module &M) {
if (!TypeCheckedLoadFunc)
return;
- for (auto U : TypeCheckedLoadFunc->users()) {
+ for (auto *U : TypeCheckedLoadFunc->users()) {
auto CI = dyn_cast<CallInst>(U);
if (!CI)
continue;
diff --git a/llvm/lib/Transforms/IPO/LowerTypeTests.cpp b/llvm/lib/Transforms/IPO/LowerTypeTests.cpp
index 69f7aba8b9be1..f722f1364667c 100644
--- a/llvm/lib/Transforms/IPO/LowerTypeTests.cpp
+++ b/llvm/lib/Transforms/IPO/LowerTypeTests.cpp
@@ -1300,7 +1300,7 @@ void LowerTypeTestsModule::replaceWeakDeclarationWithJumpTablePtr(
// (all?) targets. Switch to a runtime initializer.
SmallSetVector<GlobalVariable *, 8> GlobalVarUsers;
findGlobalVariableUsersOf(F, GlobalVarUsers);
- for (auto GV : GlobalVarUsers)
+ for (auto *GV : GlobalVarUsers)
moveInitializerToModuleConstructor(GV);
// Can not RAUW F with an expression that uses F. Replace with a temporary
@@ -1863,9 +1863,9 @@ bool LowerTypeTestsModule::lower() {
std::vector<GlobalAlias *> AliasesToErase;
{
ScopedSaveAliaseesAndUsed S(M);
- for (auto F : Defs)
+ for (auto *F : Defs)
importFunction(F, /*isJumpTableCanonical*/ true, AliasesToErase);
- for (auto F : Decls)
+ for (auto *F : Decls)
importFunction(F, /*isJumpTableCanonical*/ false, AliasesToErase);
}
for (GlobalAlias *GA : AliasesToErase)
@@ -1917,7 +1917,7 @@ bool LowerTypeTestsModule::lower() {
NamedMDNode *CfiFunctionsMD = M.getNamedMetadata("cfi.functions");
if (CfiFunctionsMD) {
- for (auto FuncMD : CfiFunctionsMD->operands()) {
+ for (auto *FuncMD : CfiFunctionsMD->operands()) {
assert(FuncMD->getNumOperands() >= 2);
StringRef FunctionName =
cast<MDString>(FuncMD->getOperand(0))->getString();
@@ -2212,7 +2212,7 @@ bool LowerTypeTestsModule::lower() {
// with an alias to the intended target.
if (ExportSummary) {
if (NamedMDNode *AliasesMD = M.getNamedMetadata("aliases")) {
- for (auto AliasMD : AliasesMD->operands()) {
+ for (auto *AliasMD : AliasesMD->operands()) {
assert(AliasMD->getNumOperands() >= 4);
StringRef AliasName =
cast<MDString>(AliasMD->getOperand(0))->getString();
@@ -2254,7 +2254,7 @@ bool LowerTypeTestsModule::lower() {
// Emit .symver directives for exported functions, if they exist.
if (ExportSummary) {
if (NamedMDNode *SymversMD = M.getNamedMetadata("symvers")) {
- for (auto Symver : SymversMD->operands()) {
+ for (auto *Symver : SymversMD->operands()) {
assert(Symver->getNumOperands() >= 2);
StringRef SymbolName =
cast<MDString>(Symver->getOperand(0))->getString();
diff --git a/llvm/lib/Transforms/IPO/SampleProfile.cpp b/llvm/lib/Transforms/IPO/SampleProfile.cpp
index 05a8c4fed4d93..062c7badca869 100644
--- a/llvm/lib/Transforms/IPO/SampleProfile.cpp
+++ b/llvm/lib/Transforms/IPO/SampleProfile.cpp
@@ -986,7 +986,7 @@ bool SampleProfileLoader::shouldInlineColdCallee(CallBase &CallInst) {
void SampleProfileLoader::emitOptimizationRemarksForInlineCandidates(
const SmallVectorImpl<CallBase *> &Candidates, const Function &F,
bool Hot) {
- for (auto I : Candidates) {
+ for (auto *I : Candidates) {
Function *CalledFunction = I->getCalledFunction();
if (CalledFunction) {
ORE->emit(OptimizationRemarkAnalysis(getAnnotatedRemarkPassName(),
@@ -2060,7 +2060,7 @@ bool SampleProfileLoader::runOnModule(Module &M, ModuleAnalysisManager *AM,
"No empty StringRef should be added in SymbolMap");
bool retval = false;
- for (auto F : buildFunctionOrder(M, CG)) {
+ for (auto *F : buildFunctionOrder(M, CG)) {
assert(!F->isDeclaration());
clearFunctionData();
retval |= runOnFunction(*F, AM);
diff --git a/llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp b/llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp
index 8744a1c51c1ac..a5d8d9a2caf35 100644
--- a/llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp
+++ b/llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp
@@ -153,7 +153,7 @@ void promoteTypeIds(Module &M, StringRef ModuleId) {
GO.getMetadata(LLVMContext::MD_type, MDs);
GO.eraseMetadata(LLVMContext::MD_type);
- for (auto MD : MDs) {
+ for (auto *MD : MDs) {
auto I = LocalToGlobal.find(MD->getOperand(1));
if (I == LocalToGlobal.end()) {
GO.addMetadata(LLVMContext::MD_type, *MD);
@@ -376,7 +376,7 @@ void splitAndWriteThinLTOBitcode(
auto &Ctx = MergedM->getContext();
SmallVector<MDNode *, 8> CfiFunctionMDs;
- for (auto V : CfiFunctions) {
+ for (auto *V : CfiFunctions) {
Function &F = *cast<Function>(V);
SmallVector<MDNode *, 2> Types;
F.getMetadata(LLVMContext::MD_type, Types);
@@ -398,7 +398,7 @@ void splitAndWriteThinLTOBitcode(
if(!CfiFunctionMDs.empty()) {
NamedMDNode *NMD = MergedM->getOrInsertNamedMetadata("cfi.functions");
- for (auto MD : CfiFunctionMDs)
+ for (auto *MD : CfiFunctionMDs)
NMD->addOperand(MD);
}
@@ -423,7 +423,7 @@ void splitAndWriteThinLTOBitcode(
if (!FunctionAliases.empty()) {
NamedMDNode *NMD = MergedM->getOrInsertNamedMetadata("aliases");
- for (auto MD : FunctionAliases)
+ for (auto *MD : FunctionAliases)
NMD->addOperand(MD);
}
@@ -439,7 +439,7 @@ void splitAndWriteThinLTOBitcode(
if (!Symvers.empty()) {
NamedMDNode *NMD = MergedM->getOrInsertNamedMetadata("symvers");
- for (auto MD : Symvers)
+ for (auto *MD : Symvers)
NMD->addOperand(MD);
}
diff --git a/llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp b/llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp
index 6b50239463418..ff61924c67b1d 100644
--- a/llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp
+++ b/llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp
@@ -1875,7 +1875,7 @@ void DevirtModule::scanTypeTestUsers(
auto RemoveTypeTestAssumes = [&]() {
// We no longer need the assumes or the type test.
- for (auto Assume : Assumes)
+ for (auto *Assume : Assumes)
Assume->eraseFromParent();
// We can't use RecursivelyDeleteTriviallyDeadInstructions here because we
// may use the vtable argument later.
@@ -2265,10 +2265,10 @@ bool DevirtModule::run() {
if (ExportSummary && isa<MDString>(S.first.TypeID)) {
auto GUID =
GlobalValue::getGUID(cast<MDString>(S.first.TypeID)->getString());
- for (auto FS : S.second.CSInfo.SummaryTypeCheckedLoadUsers)
+ for (auto *FS : S.second.CSInfo.SummaryTypeCheckedLoadUsers)
FS->addTypeTest(GUID);
for (auto &CCS : S.second.ConstCSInfo)
- for (auto FS : CCS.second.SummaryTypeCheckedLoadUsers)
+ for (auto *FS : CCS.second.SummaryTypeCheckedLoadUsers)
FS->addTypeTest(GUID);
}
}
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp b/llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
index f4d7e4cd6b9f3..d14583231082d 100644
--- a/llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
@@ -250,7 +250,7 @@ class PointerReplacer {
} // end anonymous namespace
bool PointerReplacer::collectUsers(Instruction &I) {
- for (auto U : I.users()) {
+ for (auto *U : I.users()) {
auto *Inst = cast<Instruction>(&*U);
if (auto *Load = dyn_cast<LoadInst>(Inst)) {
if (Load->isVolatile())
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp b/llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp
index 1fd12b441272b..bac1dd25c85a9 100644
--- a/llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp
@@ -105,7 +105,7 @@ Instruction *InstCombinerImpl::scalarizePHI(ExtractElementInst &EI,
// 2) Possibly more ExtractElements with the same index.
// 3) Another operand, which will feed back into the PHI.
Instruction *PHIUser = nullptr;
- for (auto U : PN->users()) {
+ for (auto *U : PN->users()) {
if (ExtractElementInst *EU = dyn_cast<ExtractElementInst>(U)) {
if (EI.getIndexOperand() == EU->getIndexOperand())
Extracts.push_back(EU);
@@ -171,7 +171,7 @@ Instruction *InstCombinerImpl::scalarizePHI(ExtractElementInst &EI,
}
}
- for (auto E : Extracts)
+ for (auto *E : Extracts)
replaceInstUsesWith(*E, scalarPHI);
return &EI;
diff --git a/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp b/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
index 80733cd043edf..73b297c7377e6 100644
--- a/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
@@ -4116,7 +4116,7 @@ static bool TryToSinkInstruction(Instruction *I, BasicBlock *DestBlock,
SmallVector<DbgVariableIntrinsic *, 2> DIIClones;
SmallSet<DebugVariable, 4> SunkVariables;
- for (auto User : DbgUsersToSink) {
+ for (auto *User : DbgUsersToSink) {
// A dbg.declare instruction should not be cloned, since there can only be
// one per variable fragment. It should be left in the original place
// because the sunk instruction is not an alloca (otherwise we could not be
diff --git a/llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp b/llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
index 87041b9da7a23..b8d4f68c00bc2 100644
--- a/llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
+++ b/llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
@@ -2733,7 +2733,7 @@ bool AddressSanitizer::instrumentFunction(Function &F,
F.getParent()->getDataLayout());
FunctionModified = true;
}
- for (auto Inst : IntrinToInstrument) {
+ for (auto *Inst : IntrinToInstrument) {
if (!suppressInstrumentationSiteForDebug(NumInstrumented))
instrumentMemIntrinsic(Inst);
FunctionModified = true;
@@ -2744,12 +2744,12 @@ bool AddressSanitizer::instrumentFunction(Function &F,
// We must unpoison the stack before NoReturn calls (throw, _exit, etc).
// See e.g. https://github.com/google/sanitizers/issues/37
- for (auto CI : NoReturnCalls) {
+ for (auto *CI : NoReturnCalls) {
IRBuilder<> IRB(CI);
IRB.CreateCall(AsanHandleNoReturnFunc, {});
}
- for (auto Inst : PointerComparisonsOrSubtracts) {
+ for (auto *Inst : PointerComparisonsOrSubtracts) {
instrumentPointerComparisonOrSubtraction(Inst);
FunctionModified = true;
}
@@ -3342,7 +3342,8 @@ void FunctionStackPoisoner::processStaticAllocas() {
}
// We are done. Remove the old unused alloca instructions.
- for (auto AI : AllocaVec) AI->eraseFromParent();
+ for (auto *AI : AllocaVec)
+ AI->eraseFromParent();
}
void FunctionStackPoisoner::poisonAlloca(Value *V, uint64_t Size,
diff --git a/llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp b/llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp
index 46c914ef1b49e..64043151a8300 100644
--- a/llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp
+++ b/llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp
@@ -259,7 +259,7 @@ class PGOCounterPromoter {
// of the loop, the result profile is incomplete.
// FIXME: add other heuristics to detect long running loops.
if (SkipRetExitBlock) {
- for (auto BB : ExitBlocks)
+ for (auto *BB : ExitBlocks)
if (isa<ReturnInst>(BB->getTerminator()))
return false;
}
diff --git a/llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp b/llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
index 3ca476e749539..05b48fb2dea4a 100644
--- a/llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
+++ b/llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
@@ -779,7 +779,7 @@ void ModuleSanitizerCoverage::InjectCoverageForIndirectCalls(
return;
assert(Options.TracePC || Options.TracePCGuard ||
Options.Inline8bitCounters || Options.InlineBoolFlag);
- for (auto I : IndirCalls) {
+ for (auto *I : IndirCalls) {
IRBuilder<> IRB(I);
CallBase &CB = cast<CallBase>(*I);
Value *Callee = CB.getCalledOperand();
@@ -795,7 +795,7 @@ void ModuleSanitizerCoverage::InjectCoverageForIndirectCalls(
void ModuleSanitizerCoverage::InjectTraceForSwitch(
Function &, ArrayRef<Instruction *> SwitchTraceTargets) {
- for (auto I : SwitchTraceTargets) {
+ for (auto *I : SwitchTraceTargets) {
if (SwitchInst *SI = dyn_cast<SwitchInst>(I)) {
IRBuilder<> IRB(I);
SmallVector<Constant *, 16> Initializers;
@@ -834,7 +834,7 @@ void ModuleSanitizerCoverage::InjectTraceForSwitch(
void ModuleSanitizerCoverage::InjectTraceForDiv(
Function &, ArrayRef<BinaryOperator *> DivTraceTargets) {
- for (auto BO : DivTraceTargets) {
+ for (auto *BO : DivTraceTargets) {
IRBuilder<> IRB(BO);
Value *A1 = BO->getOperand(1);
if (isa<ConstantInt>(A1)) continue;
@@ -852,7 +852,7 @@ void ModuleSanitizerCoverage::InjectTraceForDiv(
void ModuleSanitizerCoverage::InjectTraceForGep(
Function &, ArrayRef<GetElementPtrInst *> GepTraceTargets) {
- for (auto GEP : GepTraceTargets) {
+ for (auto *GEP : GepTraceTargets) {
IRBuilder<> IRB(GEP);
for (Use &Idx : GEP->indices())
if (!isa<ConstantInt>(Idx) && Idx->getType()->isIntegerTy())
@@ -874,7 +874,7 @@ void ModuleSanitizerCoverage::InjectTraceForLoadsAndStores(
};
Type *PointerType[5] = {Int8PtrTy, Int16PtrTy, Int32PtrTy, Int64PtrTy,
Int128PtrTy};
- for (auto LI : Loads) {
+ for (auto *LI : Loads) {
IRBuilder<> IRB(LI);
auto Ptr = LI->getPointerOperand();
int Idx = CallbackIdx(LI->getType());
@@ -883,7 +883,7 @@ void ModuleSanitizerCoverage::InjectTraceForLoadsAndStores(
IRB.CreateCall(SanCovLoadFunction[Idx],
IRB.CreatePointerCast(Ptr, PointerType[Idx]));
}
- for (auto SI : Stores) {
+ for (auto *SI : Stores) {
IRBuilder<> IRB(SI);
auto Ptr = SI->getPointerOperand();
int Idx = CallbackIdx(SI->getValueOperand()->getType());
@@ -896,7 +896,7 @@ void ModuleSanitizerCoverage::InjectTraceForLoadsAndStores(
void ModuleSanitizerCoverage::InjectTraceForCmp(
Function &, ArrayRef<Instruction *> CmpTraceTargets) {
- for (auto I : CmpTraceTargets) {
+ for (auto *I : CmpTraceTargets) {
if (ICmpInst *ICMP = dyn_cast<ICmpInst>(I)) {
IRBuilder<> IRB(ICMP);
Value *A0 = ICMP->getOperand(0);
diff --git a/llvm/lib/Transforms/Utils/CodeLayout.cpp b/llvm/lib/Transforms/Utils/CodeLayout.cpp
index b0769d948ac08..eb35c80261f8f 100644
--- a/llvm/lib/Transforms/Utils/CodeLayout.cpp
+++ b/llvm/lib/Transforms/Utils/CodeLayout.cpp
@@ -257,7 +257,7 @@ class Chain {
bool isEntry() const { return Blocks[0]->Index == 0; }
bool isCold() const {
- for (auto Block : Blocks) {
+ for (auto *Block : Blocks) {
if (Block->ExecutionCount > 0)
return false;
}
@@ -890,7 +890,7 @@ class ExtTSPImpl {
// Using doubles to avoid overflow of ExecutionCount
double Size = 0;
double ExecutionCount = 0;
- for (auto Block : Chain.blocks()) {
+ for (auto *Block : Chain.blocks()) {
Size += static_cast<double>(Block->Size);
ExecutionCount += static_cast<double>(Block->ExecutionCount);
}
diff --git a/llvm/lib/Transforms/Utils/FixIrreducible.cpp b/llvm/lib/Transforms/Utils/FixIrreducible.cpp
index 2cda72ecf9d2f..dda236167363d 100644
--- a/llvm/lib/Transforms/Utils/FixIrreducible.cpp
+++ b/llvm/lib/Transforms/Utils/FixIrreducible.cpp
@@ -137,7 +137,7 @@ static void reconnectChildLoops(LoopInfo &LI, Loop *ParentLoop, Loop *NewLoop,
// SCC gets destroyed since its backedges are removed. That may
// not be necessary if we can retain such backedges.
if (Headers.count(Child->getHeader())) {
- for (auto BB : Child->blocks()) {
+ for (auto *BB : Child->blocks()) {
if (LI.getLoopFor(BB) != Child)
continue;
LI.changeLoopFor(BB, NewLoop);
diff --git a/llvm/lib/Transforms/Utils/LCSSA.cpp b/llvm/lib/Transforms/Utils/LCSSA.cpp
index 020a40b229f77..76f2685062698 100644
--- a/llvm/lib/Transforms/Utils/LCSSA.cpp
+++ b/llvm/lib/Transforms/Utils/LCSSA.cpp
@@ -239,7 +239,7 @@ bool llvm::formLCSSAForInstructions(SmallVectorImpl<Instruction *> &Worklist,
llvm::findDbgValues(DbgValues, I);
// Update pre-existing debug value uses that reside outside the loop.
- for (auto DVI : DbgValues) {
+ for (auto *DVI : DbgValues) {
BasicBlock *UserBB = DVI->getParent();
if (InstBB == UserBB || L->contains(UserBB))
continue;
diff --git a/llvm/lib/Transforms/Utils/Local.cpp b/llvm/lib/Transforms/Utils/Local.cpp
index 25043b35b1bb2..c1735f7d85ce1 100644
--- a/llvm/lib/Transforms/Utils/Local.cpp
+++ b/llvm/lib/Transforms/Utils/Local.cpp
@@ -1653,12 +1653,12 @@ void llvm::insertDebugValuesForPHIs(BasicBlock *BB,
// propagate the info through the new PHI. If we use more than one new PHI in
// a single destination BB with the same old dbg.value, merge the updates so
// that we get a single new dbg.value with all the new PHIs.
- for (auto PHI : InsertedPHIs) {
+ for (auto *PHI : InsertedPHIs) {
BasicBlock *Parent = PHI->getParent();
// Avoid inserting an intrinsic into an EH block.
if (Parent->getFirstNonPHI()->isEHPad())
continue;
- for (auto VI : PHI->operand_values()) {
+ for (auto *VI : PHI->operand_values()) {
auto V = DbgValueMap.find(VI);
if (V != DbgValueMap.end()) {
auto *DbgII = cast<DbgVariableIntrinsic>(V->second);
diff --git a/llvm/lib/Transforms/Utils/LoopSimplify.cpp b/llvm/lib/Transforms/Utils/LoopSimplify.cpp
index 2ff8a3f7b2286..4425acd16610b 100644
--- a/llvm/lib/Transforms/Utils/LoopSimplify.cpp
+++ b/llvm/lib/Transforms/Utils/LoopSimplify.cpp
@@ -231,7 +231,7 @@ static Loop *separateNestedLoop(Loop *L, BasicBlock *Preheader,
// a function call is present until a better alternative becomes
// available. This is similar to the conservative treatment of
// convergent function calls in GVNHoist and JumpThreading.
- for (auto BB : L->blocks()) {
+ for (auto *BB : L->blocks()) {
for (auto &II : *BB) {
if (auto CI = dyn_cast<CallBase>(&II)) {
if (CI->isConvergent()) {
diff --git a/llvm/lib/Transforms/Utils/LowerGlobalDtors.cpp b/llvm/lib/Transforms/Utils/LowerGlobalDtors.cpp
index 010deb77a883a..195c274ff18e2 100644
--- a/llvm/lib/Transforms/Utils/LowerGlobalDtors.cpp
+++ b/llvm/lib/Transforms/Utils/LowerGlobalDtors.cpp
@@ -175,7 +175,7 @@ static bool runImpl(Module &M) {
FunctionType *VoidVoid = FunctionType::get(Type::getVoidTy(C),
/*isVarArg=*/false);
- for (auto Dtor : reverse(AssociatedAndMore.second))
+ for (auto *Dtor : reverse(AssociatedAndMore.second))
CallInst::Create(VoidVoid, Dtor, "", BB);
ReturnInst::Create(C, BB);
diff --git a/llvm/lib/Transforms/Utils/LowerMemIntrinsics.cpp b/llvm/lib/Transforms/Utils/LowerMemIntrinsics.cpp
index 630f586db76cf..6cb3c50bdad2e 100644
--- a/llvm/lib/Transforms/Utils/LowerMemIntrinsics.cpp
+++ b/llvm/lib/Transforms/Utils/LowerMemIntrinsics.cpp
@@ -122,7 +122,7 @@ void llvm::createMemCpyLoopKnownSize(Instruction *InsertBefore, Value *SrcAddr,
SrcAS, DstAS, SrcAlign.value(),
DstAlign.value(), AtomicElementSize);
- for (auto OpTy : RemainingOps) {
+ for (auto *OpTy : RemainingOps) {
Align PartSrcAlign(commonAlignment(SrcAlign, BytesCopied));
Align PartDstAlign(commonAlignment(DstAlign, BytesCopied));
diff --git a/llvm/lib/Transforms/Utils/PredicateInfo.cpp b/llvm/lib/Transforms/Utils/PredicateInfo.cpp
index de11b42eb9635..92bbbe6d4c299 100644
--- a/llvm/lib/Transforms/Utils/PredicateInfo.cpp
+++ b/llvm/lib/Transforms/Utils/PredicateInfo.cpp
@@ -509,7 +509,7 @@ void PredicateInfoBuilder::buildPredicateInfo() {
// Collect operands to rename from all conditional branch terminators, as well
// as assume statements.
SmallVector<Value *, 8> OpsToRename;
- for (auto DTN : depth_first(DT.getRootNode())) {
+ for (auto *DTN : depth_first(DT.getRootNode())) {
BasicBlock *BranchBB = DTN->getBlock();
if (auto *BI = dyn_cast<BranchInst>(BranchBB->getTerminator())) {
if (!BI->isConditional())
diff --git a/llvm/lib/Transforms/Utils/SampleProfileInference.cpp b/llvm/lib/Transforms/Utils/SampleProfileInference.cpp
index 5b4177bda9f93..9cbc5464a054c 100644
--- a/llvm/lib/Transforms/Utils/SampleProfileInference.cpp
+++ b/llvm/lib/Transforms/Utils/SampleProfileInference.cpp
@@ -640,7 +640,7 @@ class FlowAdjuster {
while (!Queue.empty()) {
Src = Queue.front();
Queue.pop();
- for (auto Jump : Func.Blocks[Src].SuccJumps) {
+ for (auto *Jump : Func.Blocks[Src].SuccJumps) {
uint64_t Dst = Jump->Target;
if (Jump->Flow > 0 && !Visited[Dst]) {
Queue.push(Dst);
@@ -691,7 +691,7 @@ class FlowAdjuster {
(Func.Blocks[Src].isExit() && Target == AnyExitBlock))
break;
- for (auto Jump : Func.Blocks[Src].SuccJumps) {
+ for (auto *Jump : Func.Blocks[Src].SuccJumps) {
uint64_t Dst = Jump->Target;
int64_t JumpDist = jumpDistance(Jump);
if (Distance[Dst] > Distance[Src] + JumpDist) {
@@ -795,7 +795,7 @@ class FlowAdjuster {
// Do not attempt to process subgraphs from a block w/o unknown sucessors
bool HasUnknownSuccs = false;
- for (auto Jump : SrcBlock->SuccJumps) {
+ for (auto *Jump : SrcBlock->SuccJumps) {
if (Func.Blocks[Jump->Target].UnknownWeight) {
HasUnknownSuccs = true;
break;
@@ -823,7 +823,7 @@ class FlowAdjuster {
auto &Block = Func.Blocks[Queue.front()];
Queue.pop();
// Process blocks reachable from Block
- for (auto Jump : Block.SuccJumps) {
+ for (auto *Jump : Block.SuccJumps) {
// If Jump can be ignored, skip it
if (ignoreJump(SrcBlock, nullptr, Jump))
continue;
@@ -860,7 +860,7 @@ class FlowAdjuster {
DstBlock = KnownDstBlocks.empty() ? nullptr : KnownDstBlocks.front();
// Verify sinks of the subgraph
- for (auto Block : UnknownBlocks) {
+ for (auto *Block : UnknownBlocks) {
if (Block->SuccJumps.empty()) {
// If there are multiple (known and unknown) sinks, we can't rebalance
if (DstBlock != nullptr)
@@ -868,7 +868,7 @@ class FlowAdjuster {
continue;
}
size_t NumIgnoredJumps = 0;
- for (auto Jump : Block->SuccJumps) {
+ for (auto *Jump : Block->SuccJumps) {
if (ignoreJump(SrcBlock, DstBlock, Jump))
NumIgnoredJumps++;
}
@@ -914,14 +914,14 @@ class FlowAdjuster {
// Extract local in-degrees in the considered subgraph
auto LocalInDegree = std::vector<uint64_t>(NumBlocks(), 0);
auto fillInDegree = [&](const FlowBlock *Block) {
- for (auto Jump : Block->SuccJumps) {
+ for (auto *Jump : Block->SuccJumps) {
if (ignoreJump(SrcBlock, DstBlock, Jump))
continue;
LocalInDegree[Jump->Target]++;
}
};
fillInDegree(SrcBlock);
- for (auto Block : UnknownBlocks) {
+ for (auto *Block : UnknownBlocks) {
fillInDegree(Block);
}
// A loop containing SrcBlock
@@ -943,7 +943,7 @@ class FlowAdjuster {
AcyclicOrder.push_back(Block);
// Add to the queue all successors with zero local in-degree
- for (auto Jump : Block->SuccJumps) {
+ for (auto *Jump : Block->SuccJumps) {
if (ignoreJump(SrcBlock, DstBlock, Jump))
continue;
uint64_t Dst = Jump->Target;
@@ -972,7 +972,7 @@ class FlowAdjuster {
// Ditribute flow from the source block
uint64_t BlockFlow = 0;
// SrcBlock's flow is the sum of outgoing flows along non-ignored jumps
- for (auto Jump : SrcBlock->SuccJumps) {
+ for (auto *Jump : SrcBlock->SuccJumps) {
if (ignoreJump(SrcBlock, DstBlock, Jump))
continue;
BlockFlow += Jump->Flow;
@@ -980,11 +980,11 @@ class FlowAdjuster {
rebalanceBlock(SrcBlock, DstBlock, SrcBlock, BlockFlow);
// Ditribute flow from the remaining blocks
- for (auto Block : UnknownBlocks) {
+ for (auto *Block : UnknownBlocks) {
assert(Block->UnknownWeight && "incorrect unknown subgraph");
uint64_t BlockFlow = 0;
// Block's flow is the sum of incoming flows
- for (auto Jump : Block->PredJumps) {
+ for (auto *Jump : Block->PredJumps) {
BlockFlow += Jump->Flow;
}
Block->Flow = BlockFlow;
@@ -998,7 +998,7 @@ class FlowAdjuster {
const FlowBlock *Block, uint64_t BlockFlow) {
// Process all successor jumps and update corresponding flow values
size_t BlockDegree = 0;
- for (auto Jump : Block->SuccJumps) {
+ for (auto *Jump : Block->SuccJumps) {
if (ignoreJump(SrcBlock, DstBlock, Jump))
continue;
BlockDegree++;
@@ -1011,7 +1011,7 @@ class FlowAdjuster {
// Each of the Block's successors gets the following amount of flow.
// Rounding the value up so that all flow is propagated
uint64_t SuccFlow = (BlockFlow + BlockDegree - 1) / BlockDegree;
- for (auto Jump : Block->SuccJumps) {
+ for (auto *Jump : Block->SuccJumps) {
if (ignoreJump(SrcBlock, DstBlock, Jump))
continue;
uint64_t Flow = std::min(SuccFlow, BlockFlow);
diff --git a/llvm/lib/Transforms/Utils/SimplifyCFG.cpp b/llvm/lib/Transforms/Utils/SimplifyCFG.cpp
index 7f2fb10183ca7..0dab4f4d69ef3 100644
--- a/llvm/lib/Transforms/Utils/SimplifyCFG.cpp
+++ b/llvm/lib/Transforms/Utils/SimplifyCFG.cpp
@@ -5684,13 +5684,13 @@ static Value *foldSwitchToSelect(const SwitchCaseResultVectorTy &ResultVector,
if (isPowerOf2_32(CaseCount)) {
ConstantInt *MinCaseVal = CaseValues[0];
// Find mininal value.
- for (auto Case : CaseValues)
+ for (auto *Case : CaseValues)
if (Case->getValue().slt(MinCaseVal->getValue()))
MinCaseVal = Case;
// Mark the bits case number touched.
APInt BitMask = APInt::getZero(MinCaseVal->getBitWidth());
- for (auto Case : CaseValues)
+ for (auto *Case : CaseValues)
BitMask |= (Case->getValue() - MinCaseVal->getValue());
// Check if cases with the same result can cover all number
diff --git a/llvm/lib/Transforms/Utils/UnifyLoopExits.cpp b/llvm/lib/Transforms/Utils/UnifyLoopExits.cpp
index 9bbfe06b9abbd..03140ef7feb1e 100644
--- a/llvm/lib/Transforms/Utils/UnifyLoopExits.cpp
+++ b/llvm/lib/Transforms/Utils/UnifyLoopExits.cpp
@@ -88,7 +88,7 @@ static void restoreSSA(const DominatorTree &DT, const Loop *L,
using InstVector = SmallVector<Instruction *, 8>;
using IIMap = MapVector<Instruction *, InstVector>;
IIMap ExternalUsers;
- for (auto BB : L->blocks()) {
+ for (auto *BB : L->blocks()) {
for (auto &I : *BB) {
for (auto &U : I.uses()) {
auto UserInst = cast<Instruction>(U.getUser());
@@ -117,7 +117,7 @@ static void restoreSSA(const DominatorTree &DT, const Loop *L,
auto NewPhi = PHINode::Create(Def->getType(), Incoming.size(),
Def->getName() + ".moved",
LoopExitBlock->getTerminator());
- for (auto In : Incoming) {
+ for (auto *In : Incoming) {
LLVM_DEBUG(dbgs() << "predecessor " << In->getName() << ": ");
if (Def->getParent() == In || DT.dominates(Def, In)) {
LLVM_DEBUG(dbgs() << "dominated\n");
@@ -129,7 +129,7 @@ static void restoreSSA(const DominatorTree &DT, const Loop *L,
}
LLVM_DEBUG(dbgs() << "external users:");
- for (auto U : II.second) {
+ for (auto *U : II.second) {
LLVM_DEBUG(dbgs() << " " << U->getName());
U->replaceUsesOfWith(Def, NewPhi);
}
@@ -149,9 +149,9 @@ static bool unifyLoopExits(DominatorTree &DT, LoopInfo &LI, Loop *L) {
// We need SetVectors, but the Loop API takes a vector, so we use a temporary.
SmallVector<BasicBlock *, 8> Temp;
L->getExitingBlocks(Temp);
- for (auto BB : Temp) {
+ for (auto *BB : Temp) {
ExitingBlocks.insert(BB);
- for (auto S : successors(BB)) {
+ for (auto *S : successors(BB)) {
auto SL = LI.getLoopFor(S);
// A successor is not an exit if it is directly or indirectly in the
// current loop.
@@ -196,7 +196,7 @@ static bool unifyLoopExits(DominatorTree &DT, LoopInfo &LI, Loop *L) {
// The guard blocks were created outside the loop, so they need to become
// members of the parent loop.
if (auto ParentLoop = L->getParentLoop()) {
- for (auto G : GuardBlocks) {
+ for (auto *G : GuardBlocks) {
ParentLoop->addBasicBlockToLoop(G, LI);
}
ParentLoop->verifyLoop();
@@ -213,7 +213,7 @@ static bool runImpl(LoopInfo &LI, DominatorTree &DT) {
bool Changed = false;
auto Loops = LI.getLoopsInPreorder();
- for (auto L : Loops) {
+ for (auto *L : Loops) {
LLVM_DEBUG(dbgs() << "Loop: " << L->getHeader()->getName() << " (depth: "
<< LI.getLoopDepth(L->getHeader()) << ")\n");
Changed |= unifyLoopExits(DT, LI, L);
diff --git a/llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp b/llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp
index e271c1af87ce4..662f9caa14bb2 100644
--- a/llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp
+++ b/llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp
@@ -295,7 +295,7 @@ void LoopVectorizeHints::setHint(StringRef Name, Metadata *Arg) {
Hint *Hints[] = {&Width, &Interleave, &Force,
&IsVectorized, &Predicate, &Scalable};
- for (auto H : Hints) {
+ for (auto *H : Hints) {
if (Name == H->Name) {
if (H->validate(Val))
H->Value = Val;
diff --git a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
index 244b2875d0430..6d628c5e32a5b 100644
--- a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
+++ b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
@@ -4738,7 +4738,7 @@ void LoopVectorizationCostModel::collectLoopUniforms(ElementCount VF) {
while (idx != Worklist.size()) {
Instruction *I = Worklist[idx++];
- for (auto OV : I->operand_values()) {
+ for (auto *OV : I->operand_values()) {
// isOutOfScope operands cannot be uniform instructions.
if (isOutOfScope(OV))
continue;
@@ -5991,7 +5991,7 @@ LoopVectorizationCostModel::calculateRegisterUsage(ArrayRef<ElementCount> VFs) {
SmallMapVector<unsigned, unsigned, 4> RegUsage;
if (VFs[j].isScalar()) {
- for (auto Inst : OpenIntervals) {
+ for (auto *Inst : OpenIntervals) {
unsigned ClassID = TTI.getRegisterClassForType(false, Inst->getType());
if (RegUsage.find(ClassID) == RegUsage.end())
RegUsage[ClassID] = 1;
@@ -6000,7 +6000,7 @@ LoopVectorizationCostModel::calculateRegisterUsage(ArrayRef<ElementCount> VFs) {
}
} else {
collectUniformsAndScalars(VFs[j]);
- for (auto Inst : OpenIntervals) {
+ for (auto *Inst : OpenIntervals) {
// Skip ignored values for VF > 1.
if (VecValuesToIgnore.count(Inst))
continue;
@@ -6038,7 +6038,7 @@ LoopVectorizationCostModel::calculateRegisterUsage(ArrayRef<ElementCount> VFs) {
for (unsigned i = 0, e = VFs.size(); i < e; ++i) {
SmallMapVector<unsigned, unsigned, 4> Invariant;
- for (auto Inst : LoopInvariants) {
+ for (auto *Inst : LoopInvariants) {
unsigned Usage =
VFs[i].isScalar() ? 1 : GetRegUsage(Inst->getType(), VFs[i]);
unsigned ClassID =
diff --git a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
index 197cc7841285e..5fe4aef4f1664 100644
--- a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
+++ b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
@@ -3326,7 +3326,7 @@ template <> struct DOTGraphTraits<BoUpSLP *> : public DefaultDOTGraphTraits {
raw_string_ostream OS(Str);
if (isSplat(Entry->Scalars))
OS << "<splat> ";
- for (auto V : Entry->Scalars) {
+ for (auto *V : Entry->Scalars) {
OS << *V;
if (llvm::any_of(R->ExternalUses, [&](const BoUpSLP::ExternalUser &EU) {
return EU.Scalar == V;
@@ -10057,7 +10057,7 @@ bool SLPVectorizerPass::runImpl(Function &F, ScalarEvolution *SE_,
DT->updateDFSNumbers();
// Scan the blocks in the function in post order.
- for (auto BB : post_order(&F.getEntryBlock())) {
+ for (auto *BB : post_order(&F.getEntryBlock())) {
// Start new block - clear the list of reduction roots.
R.clearReductionData();
collectSeedInstructions(BB);
diff --git a/llvm/lib/Transforms/Vectorize/VPlanSLP.cpp b/llvm/lib/Transforms/Vectorize/VPlanSLP.cpp
index 3a7e77fd9efd4..0210afa1a0c9c 100644
--- a/llvm/lib/Transforms/Vectorize/VPlanSLP.cpp
+++ b/llvm/lib/Transforms/Vectorize/VPlanSLP.cpp
@@ -343,7 +343,7 @@ SmallVector<VPlanSlp::MultiNodeOpTy, 4> VPlanSlp::reorderMultiNodeOps() {
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
void VPlanSlp::dumpBundle(ArrayRef<VPValue *> Values) {
dbgs() << " Ops: ";
- for (auto Op : Values) {
+ for (auto *Op : Values) {
if (auto *VPInstr = cast_or_null<VPInstruction>(Op))
if (auto *Instr = VPInstr->getUnderlyingInstr()) {
dbgs() << *Instr << " | ";
diff --git a/llvm/lib/Transforms/Vectorize/VectorCombine.cpp b/llvm/lib/Transforms/Vectorize/VectorCombine.cpp
index 0107a55b07f25..1f5f83816b728 100644
--- a/llvm/lib/Transforms/Vectorize/VectorCombine.cpp
+++ b/llvm/lib/Transforms/Vectorize/VectorCombine.cpp
@@ -1297,7 +1297,7 @@ bool VectorCombine::foldSelectShuffle(Instruction &I, bool FromReduction) {
// cost calculations.
if (!FromReduction) {
for (ShuffleVectorInst *SV : Shuffles) {
- for (auto U : SV->users()) {
+ for (auto *U : SV->users()) {
ShuffleVectorInst *SSV = dyn_cast<ShuffleVectorInst>(U);
if (SSV && isa<UndefValue>(SSV->getOperand(1)) && SSV->getType() == VT)
Shuffles.push_back(SSV);
More information about the llvm-commits
mailing list