[PATCH] D132443: [LSR] Fold terminal condition to other IV when possible

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 27 14:55:17 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:189
 
+static cl::opt<bool> AllowTerminalConditionFoldingAfterLSR(
+    "lsr-term-fold", cl::Hidden, cl::init(false),
----------------
eopXD wrote:
> craig.topper wrote:
> > Terminal -> Terminating? The word terminal does not appear in LSR prior to this patch.
> Replaced all use of "terminal condition" to "terminating condition". 
The option name still says `Terminal`

Review needs to re-titled and the description needs to be updated


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132443/new/

https://reviews.llvm.org/D132443



More information about the llvm-commits mailing list