[PATCH] D132036: [llvm-objdump] Add -dyld_info to llvm-otool

[Daniel Bertalan via Phabricator via llvm-commits]

BertalanD added inline comments.


================
Comment at: llvm/tools/llvm-objdump/MachODump.cpp:1362
+    consumeError(std::move(Err));
+    Err = Error::success();
+  }
----------------
thakis wrote:
> nit: Not sure if this line is necessary; Error's move ctor comment sounds a bit like it already does this to the moved-from value: http://llvm-cs.pcc.me.uk/include/llvm/Support/Error.h#190
But then, we'd do a use-after-move later in the function, which is a bit dodgy.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132036/new/

https://reviews.llvm.org/D132036