[llvm] 3dcec5e - [LV] Consistently use vputils::isUniformAfterVectorization [mostly nfc]

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 27 14:23:23 PDT 2022



> On Aug 26, 2022, at 19:09, Philip Reames via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> 
> Author: Philip Reames
> Date: 2022-08-26T11:09:17-07:00
> New Revision: 3dcec5e29ff73d9f42b364885119105b69c2bb37
> 
> URL: https://github.com/llvm/llvm-project/commit/3dcec5e29ff73d9f42b364885119105b69c2bb37
> DIFF: https://github.com/llvm/llvm-project/commit/3dcec5e29ff73d9f42b364885119105b69c2bb37.diff
> 
> LOG: [LV] Consistently use vputils::isUniformAfterVectorization [mostly nfc]
> 
> I'd extracted isUniform, and Florian moved isUniformAfterVectorization out of VPlan at basically the same time. Let's go ahead and merge them.
> 
> For the VPTransformState::get path, a VPValue without a def (which corresponds to an external IR value outside of VPLan) is explicitly handled above the uniform check.  On the scalarizeInstruction path, I'm less sure why the change isn't visible, but test cases which would seem likely to hit it were already being handled as uniform through some other mechanism.  It would be correct to consider values defined outside of vplan uniform here.
> 

Thanks! I was planning to do the same but you beat me to it :)




More information about the llvm-commits mailing list