[PATCH] D131989: [VPlan] Verify that header only contains header phi recipes.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1137
   static inline bool classof(const VPRecipeBase *B) {
     return B->getVPDefID() == VPRecipeBase::VPCanonicalIVPHISC ||
            B->getVPDefID() == VPRecipeBase::VPActiveLaneMaskPHISC ||
----------------
Ayal wrote:
> Phi-like recipes are kept in order to facilitate checking intervals (and help avoid such missed-case bugs)?
I'll do that separately.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanVerifier.cpp:140
   // Verify that phi-like recipes are at the beginning of the block, with no
   // other recipes in between.
   auto RecipeI = VPBB->begin();
----------------
Ayal wrote:
> Perhaps worth outlining the first part that verifies phi recipes, breaking the somewhat long method into two?
Done!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131989/new/

https://reviews.llvm.org/D131989