[PATCH] D132601: [llvm-profdata] Improve profile supplementation

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/lib/ProfileData/InstrProf.cpp:736
+
+  for (size_t I = Start, E = Other.Counts.size(); I < E; ++I) {
     bool Overflowed;
----------------
should this loop be skipped for pseudo kind?


================
Comment at: llvm/lib/ProfileData/ProfileSummaryBuilder.cpp:234
 void InstrProfSummaryBuilder::addInternalCount(uint64_t Count) {
-  // Skip invalid count.
-  if (Count == (uint64_t)-1)
-    return;
-
   addCount(Count);
   if (Count > MaxInternalBlockCount)
----------------
add assert on count value (not pseudo values).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132601/new/

https://reviews.llvm.org/D132601