[PATCH] D132753: [llvm][Testing/ADT] Implement `IsStringMapEntry` testing matcher for verifying the entries in a `StringMap`.

[Dmitri Gribenko via Phabricator via llvm-commits]

gribozavr2 added inline comments.


================
Comment at: llvm/include/llvm/ADT/StringMapEntry.h:104
 public:
+  typedef ValueTy ValueType;
+
----------------



================
Comment at: llvm/include/llvm/Testing/ADT/StringMapEntryMatcher.h:20-21
+public:
+  typedef
+      typename std::remove_reference<StringMapEntryT>::type::ValueType ValueT;
+
----------------



================
Comment at: llvm/unittests/Testing/ADT/StringMapEntryMatcherTest.cpp:58
+TEST(IsStringMapEntryTest, DescribeSelf) {
+  llvm::StringMap<int> Map = {{"A", 1}};
+  Matcher<llvm::StringMapEntry<int>> M = IsStringMapEntry("A", 1);
----------------
Unused variable?


================
Comment at: llvm/unittests/Testing/CMakeLists.txt:1-2
 add_subdirectory(Support)
+add_subdirectory(ADT)
----------------
Please sort.


================
Comment at: utils/bazel/llvm-project-overlay/llvm/BUILD.bazel:4178
 
+cc_library(
+    name = "testing_adt",
----------------
Could you put it right before TestingSupport (below), and call it TestingADT (to follow the existing camel case naming convention)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132753/new/

https://reviews.llvm.org/D132753