[PATCH] D132764: [LazyCallGraph] Update libcall list when replacing a libcall node's function

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks created this revision.
aeubanks added reviewers: psamolysov, asbirlea.
Herald added a subscriber: hiraditya.
Herald added a project: All.
aeubanks requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Otherwise when we visit all libcalls in
updateCGAndAnalysisManagerForPass(), the old libcall is dead and doesn't
have a node.

We treat libcalls conservatively in LazyCallGraph because any function
may introduce calls to them out of thin air.

It is weird to change the signature of a libcall since introducing calls
to the libcall with a different signature may break, but other passes
like deadargelim already do it, so let's preserve this behavior for now.

Fixes an issue found in D128830 <https://reviews.llvm.org/D128830>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D132764

Files:
  llvm/lib/Analysis/LazyCallGraph.cpp
  llvm/test/Analysis/LazyCallGraph/replace-libcall.ll


Index: llvm/test/Analysis/LazyCallGraph/replace-libcall.ll
===================================================================
--- /dev/null
+++ llvm/test/Analysis/LazyCallGraph/replace-libcall.ll
@@ -0,0 +1,17 @@
+; RUN: opt -passes=inline,argpromotion < %s -S | FileCheck %s
+
+; Make sure we update the list of libcalls when we replace a libcall.
+
+; CHECK: define {{.*}}@a
+
+define void @a() {
+entry:
+  %call = call float @strtof(ptr noundef null, ptr noundef null)
+  ret void
+}
+
+define internal float @strtof(ptr noundef %0, ptr noundef %1) nounwind {
+entry:
+  ret float 0.0
+}
+
Index: llvm/lib/Analysis/LazyCallGraph.cpp
===================================================================
--- llvm/lib/Analysis/LazyCallGraph.cpp
+++ llvm/lib/Analysis/LazyCallGraph.cpp
@@ -1484,6 +1484,12 @@
   // Update various call graph maps.
   G->NodeMap.erase(&OldF);
   G->NodeMap[&NewF] = &N;
+
+  // Update lib functions.
+  if (G->isLibFunction(OldF)) {
+    G->LibFunctions.remove(&OldF);
+    G->LibFunctions.insert(&NewF);
+  }
 }
 
 void LazyCallGraph::insertEdge(Node &SourceN, Node &TargetN, Edge::Kind EK) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132764.456033.patch
Type: text/x-patch
Size: 1126 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220826/025904ad/attachment.bin>