[PATCH] D131142: [InstCombine] Canonicalize "and, add", "or, add", "xor, add"

Eric Gullufsen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 26 14:18:09 PDT 2022


emgullufsen added a comment.

In D131142#3752708 <https://reviews.llvm.org/D131142#3752708>, @reames wrote:

> In D131142#3752707 <https://reviews.llvm.org/D131142#3752707>, @emgullufsen wrote:
>
>> Thanks for reverting @reames - when you have a second maybe you could please have a look over this updated patch?
>
> No need.  I reverted because of a broken test, if that's been fixed, your LGTM stands.

Cool I see - I didn't think I needed to ask for review from reverting dev from Developer Policy, but just wanted to be sure I guess. Thanks again to you and to @spatel for help with proofs and review. Will be more careful with tests in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131142/new/

https://reviews.llvm.org/D131142



More information about the llvm-commits mailing list