[PATCH] D132725: [llvm][CodeGen] Skip WinCFGuard on non-Windows targets

[John McCall via Phabricator via llvm-commits]

rjmccall added a comment.

Emitting IR to support CFGuard but then ignoring it in hacky ways in the backend just seems wrong.  If there's never going to be an effort to support it outside of Windows, then it shouldn't go into the IR at all; if there is, then all parts of the systems should do their best, with an understanding that it may not work because it's experimental at best.

There are three reasonable alternatives here, and we should pick one of them:

1. CFGuard on non-Windows is an unwanted feature, and we should handle frontend requests for it by emitting an error.
2. CFGuard on non-Windows is an unwanted feature, and we should handle frontend requests for it by ignoring them.
3. CFGuard on non-Windows is an unsupported, experimental feature that users shouldn't request unless they're willing to accept that things will break because it's not complete yet (and may not be for the indefinite future).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132725/new/

https://reviews.llvm.org/D132725