[PATCH] D132315: [Orc] Use MapperJITLinkMemoryManager with InProcessMapper in llvm-jitlink tool

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 26 12:03:15 PDT 2022


lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.

Otherwise LGTM!



================
Comment at: llvm/tools/llvm-jitlink/llvm-jitlink.cpp:458
 
+// A memory mapper with a fake offset applied mostly used for testing
+class InProcessDeltaMapper final : public InProcessMemoryMapper {
----------------
I'd change this to "only used for -noexec testing" -- I don't think there's any other use case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132315/new/

https://reviews.llvm.org/D132315



More information about the llvm-commits mailing list