[PATCH] D131959: [AMDGPU] Fix SDST operand of V_DIV_SCALE to always be VCC

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 26 11:39:01 PDT 2022


rampitec added a comment.

In D131959#3748543 <https://reviews.llvm.org/D131959#3748543>, @Pierre-vh wrote:

> So far, if I understand correctly, my changes only affect the asm parser, but not yet the printer, correct? That's why I'm not seeing vcc_lo in the output.
> It seems like some changes are needed on that front but I'm not sure where/how as it looks like this is the first VOP3 instruction to need special casing to print vcc/vcc_lo?
>
> Maybe in `needsImpliedVcc`?

Yes, something along these lines and call `printDefaultVccOperand`. There are similar cases handled there but not 100% the same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131959/new/

https://reviews.llvm.org/D131959



More information about the llvm-commits mailing list