[PATCH] D129660: [IR] Add Instruction::getAfterDefInsertionPoint()

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/lib/IR/Instruction.cpp:131
+    InsertBB = CB->getDefaultDest();
+    InsertPt = InsertBB->getFirstInsertionPt();
+  } else {
----------------
efriedma wrote:
> I think for CallBrInst, we're considering modifying the dominance rules to allow the produced value to be used in all destinations?  In which case there wouldn't be one unique location after the definition.
> I think for CallBrInst, we're considering modifying the dominance rules to allow the produced value to be used in all destinations?

Yes; GCC implemented asm goto w/ outputs this way; we should update our implementation, too. @morbo and I were just discussing this on Tuesday.

https://github.com/llvm/llvm-project/issues/53562


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129660/new/

https://reviews.llvm.org/D129660