[PATCH] D132731: [AMDGPU][MC][GFX11][NFC] Update disassembler tests for VOP1 and VOP1.DPP instructions

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 26 11:04:52 PDT 2022


dp added a comment.

In D132731#3752259 <https://reviews.llvm.org/D132731#3752259>, @Joe_Nash wrote:

> For these test and the other test updates, has the both the output and input been generated external to LLVM? Basically can we consider the output cross-checked against anything outside LLVM, or is the output simply what LLVM generates from the input.

Both the input and output are external to LLVM with one exception. When generating WS-dependent tests (e.g. for `v_add_co_ci`) I can only produce tests for one WS value. I have a script that merges WS32 and WS64 tests, but it currently works with asm tests only. For disassembler, I do use LLVM output for such instructions as a workaround.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132731/new/

https://reviews.llvm.org/D132731



More information about the llvm-commits mailing list