[PATCH] D132452: [LSR] Precommit test for D132443

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/test/Transforms/LoopStrengthReduce/lsr-fold-iv-runtime-tripcount.ll:84
+  %arrayidx = getelementptr inbounds i8, ptr %call, i64 %idxprom
+  store i8 %conv1, ptr %arrayidx, align 1
+  store i8 %conv1, ptr %call, align 1
----------------
is all those here really needed?


================
Comment at: llvm/test/Transforms/LoopStrengthReduce/lsr-fold-iv-runtime-tripcount.ll:93
+  %sub16 = add i32 %0, 255
+  %conv1730 = zext i32 %sub16 to i64
+  %wide.trip.count = zext i32 %add2 to i64
----------------
is all this here really needed?


================
Comment at: llvm/test/Transforms/LoopStrengthReduce/lsr-fold-iv-runtime-tripcount.ll:112
+  %sub.ptr.sub = sub i64 %sub.ptr.lhs.cast, ptrtoint (ptr @Alphabet to i64)
+  %cond = select i1 %cmp14, i64 %conv1730, i64 %sub.ptr.sub
+  %conv18 = trunc i64 %cond to i8
----------------
is all those here really needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132452/new/

https://reviews.llvm.org/D132452