[PATCH] D104432: [Attributor] Introduce AAPointerInfo

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:1203
+        for (Use &Idx : llvm::make_range(GEP->idx_begin(), GEP->idx_end())) {
+          if (auto *CIdx = dyn_cast<ConstantInt>(Idx)) {
+            Indices.push_back(CIdx);
----------------
sameerds wrote:
> Old change, but when is this condition false? Just above this, there is an early return if any index is not a constant.
You are right. Feel free to remove this and use cast<..>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104432/new/

https://reviews.llvm.org/D104432