[PATCH] D132537: [RISCV][NFC] Add cost model coverage for fp arithmetic instructions.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 26 07:51:26 PDT 2022


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM.  Duplicate testing noted, please remove before landing.

p.s. I'm working on intrinsic costing, you might find https://github.com/preames/riscv-llvm-cost-model-gen/ useful, and feel free to tag me on reviews.  I'm motivated to see these fixed and landed.



================
Comment at: llvm/test/Analysis/CostModel/RISCV/arith-fp.ll:486
+
+define i32 @fsqrt() {
+; CHECK-LABEL: 'fsqrt'
----------------
sqrt already has test coverage - very recently added - in fp-sqrt-pow.ll.  Please remove here.


================
Comment at: llvm/test/Analysis/CostModel/RISCV/arith-fp.ll:566
+
+define i32 @fabs() {
+; CHECK-LABEL: 'fabs'
----------------
Already covered in fp-min-max-abs.ll


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132537/new/

https://reviews.llvm.org/D132537



More information about the llvm-commits mailing list