[PATCH] D132722: [RISCV][NFC] Refactor fadd test to match the code.

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM

However, we really should have tests for both forms.  Please land, but then add another test with the source operand being used instead.  Please add a corresponding test for each intrinsic with a scalar fold start operand.



================
Comment at: llvm/test/CodeGen/RISCV/rvv/fold-binary-reduce.ll:256
+  %rdx = call fast float @llvm.vector.reduce.fadd.v4f32(float 0.0, <4 x float> %v)
+  %res = fadd reassoc nsz float %rdx, %x
+  ret float %res
----------------
Use fast here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132722/new/

https://reviews.llvm.org/D132722