[PATCH] D131309: [ELF] Add ability to get a symbol by name from the hash table section

Joseph Huber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 26 04:32:40 PDT 2022


jhuber6 added a comment.

In D131309#3751136 <https://reviews.llvm.org/D131309#3751136>, @JonChesterfield wrote:

> This patch wants to move code from the openmp runtime into llvm. I'm not convinced that has any value relative to leaving it where it already is, perhaps Joseph would be better off applying these review induced changes to the runtime instead.

That's probably the best road forward if this is a blocker, as it no longer provides the functionality we need. Most of the code can be directly put in the runtime instead, but it would be nice to have all the runtime and correctness tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131309/new/

https://reviews.llvm.org/D131309



More information about the llvm-commits mailing list