[PATCH] D131433: [ARM] Use getSymbolPreferLocal() in GetARMGVSymbol
Alexander Richardson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 26 02:34:47 PDT 2022
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGdf00dac828d7: [ARM] Use getSymbolPreferLocal() in GetARMGVSymbol (authored by arichardson).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131433/new/
https://reviews.llvm.org/D131433
Files:
llvm/lib/Target/ARM/ARMAsmPrinter.cpp
llvm/test/CodeGen/ARM/dso-local-func.ll
llvm/test/CodeGen/ARM/elf-preemption.ll
llvm/test/CodeGen/ARM/thumb-function-section-reloc.ll
Index: llvm/test/CodeGen/ARM/thumb-function-section-reloc.ll
===================================================================
--- llvm/test/CodeGen/ARM/thumb-function-section-reloc.ll
+++ llvm/test/CodeGen/ARM/thumb-function-section-reloc.ll
@@ -17,10 +17,10 @@
; RELOCS-NEXT: 0x0 R_ARM_PREL31 .text._ZdlPv
; RELOCS-NEXT: }
; RELOCS-NEXT: Section (7) .rel.text.test {
-; RELOCS-NEXT: 0x4 R_ARM_CALL _ZdlPv
+; RELOCS-NEXT: 0x4 R_ARM_CALL .L_ZdlPv$local
; RELOCS-NEXT: 0xC R_ARM_ABS32 .L_ZdlPv$local
; RELOCS-NEXT: 0x10 R_ARM_ABS32 .L_ZdlPv$local
-; RELOCS-NEXT: 0x1C R_ARM_REL32 _ZdlPv
+; RELOCS-NEXT: 0x1C R_ARM_REL32 .L_ZdlPv$local
; RELOCS-NEXT: }
; RELOCS-NEXT: Section (9) .rel.ARM.exidx.text.test {
; RELOCS-NEXT: 0x0 R_ARM_PREL31 .text.test
@@ -67,7 +67,7 @@
; CHECK: @ %bb.0: @ %entry
; CHECK-NEXT: .save {r11, lr}
; CHECK-NEXT: push {r11, lr}
-; CHECK-NEXT: bl _ZdlPv{{$}}
+; CHECK-NEXT: bl .L_ZdlPv$local
; CHECK-NEXT: ldr r0, .LCPI1_0
; CHECK-NEXT: @APP
; CHECK-NEXT: .long .L_ZdlPv$local
@@ -83,7 +83,7 @@
; CHECK-NEXT: .p2align 2
; CHECK-NEXT: @ %bb.1:
; CHECK-NEXT: .LCPI1_0:
-; CHECK-NEXT: .long _ZdlPv-(.LPC1_0+8)
+; CHECK-NEXT: .long .L_ZdlPv$local-(.LPC1_0+8)
entry:
call void @_ZdlPv(ptr %ptr)
; This inline assembly is needed to highlight the missing Thumb LSB since
Index: llvm/test/CodeGen/ARM/elf-preemption.ll
===================================================================
--- llvm/test/CodeGen/ARM/elf-preemption.ll
+++ llvm/test/CodeGen/ARM/elf-preemption.ll
@@ -43,7 +43,7 @@
; PIC-NEXT: .p2align 2
; PIC-NEXT: @ %bb.1:
; PIC-NEXT: .LCPI1_0:
-; PIC-NEXT: .long dsolocal_var-(.LPC1_0+8)
+; PIC-NEXT: .long .Ldsolocal_var$local-(.LPC1_0+8)
ret ptr @dsolocal_var
}
@@ -147,7 +147,7 @@
; PIC-NEXT: .p2align 2
; PIC-NEXT: @ %bb.1:
; PIC-NEXT: .LCPI6_0:
-; PIC-NEXT: .long dsolocal_func-(.LPC6_0+8)
+; PIC-NEXT: .long .Ldsolocal_func$local-(.LPC6_0+8)
ret ptr @dsolocal_func
}
@@ -185,7 +185,7 @@
; PIC: @ %bb.0:
; PIC-NEXT: .save {r11, lr}
; PIC-NEXT: push {r11, lr}
-; PIC-NEXT: bl dsolocal_func
+; PIC-NEXT: bl .Ldsolocal_func$local
; PIC-NEXT: pop {r11, pc}
call ptr @dsolocal_func()
ret void
Index: llvm/test/CodeGen/ARM/dso-local-func.ll
===================================================================
--- llvm/test/CodeGen/ARM/dso-local-func.ll
+++ llvm/test/CodeGen/ARM/dso-local-func.ll
@@ -24,7 +24,7 @@
; PIC-NEXT: .p2align 2
; PIC-NEXT: @ %bb.1:
; PIC-NEXT: .LCPI0_0:
-; PIC-NEXT: .long dsolocal_func-(.LPC0_0+8)
+; PIC-NEXT: .long .Ldsolocal_func$local-(.LPC0_0+8)
; CHECK-NEXT: .Lfunc_end0:
; CHECK-NEXT: .size dsolocal_func, .Lfunc_end0-dsolocal_func
; PIC-NEXT: .size .Ldsolocal_func$local, .Lfunc_end0-dsolocal_func
Index: llvm/lib/Target/ARM/ARMAsmPrinter.cpp
===================================================================
--- llvm/lib/Target/ARM/ARMAsmPrinter.cpp
+++ llvm/lib/Target/ARM/ARMAsmPrinter.cpp
@@ -891,7 +891,7 @@
return MCSym;
} else if (Subtarget->isTargetELF()) {
- return getSymbol(GV);
+ return getSymbolPreferLocal(*GV);
}
llvm_unreachable("unexpected target");
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131433.455837.patch
Type: text/x-patch
Size: 3261 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220826/b245298c/attachment-0001.bin>
More information about the llvm-commits
mailing list