[PATCH] D132580: [Coro][Debuginfo] Add debug info to `_NoopCoro_ResumeDestroy` function

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu added inline comments.


================
Comment at: llvm/lib/Transforms/Coroutines/CoroEarly.cpp:111
+  DIBuilder DB(M, /*AllowUnresolved*/ false, CU);
+  auto *File = DB.createFile("<llvm-intrinsics>", "");
+  std::array<Metadata *, 2> Params{nullptr, nullptr};
----------------
How about using existing DIFile?


================
Comment at: llvm/lib/Transforms/Coroutines/CoroEarly.cpp:147-150
+    Constant *Values[] = {NoopFn, NoopFn};
+    Constant *NoopCoroConst = ConstantStruct::get(FrameTy, Values);
+    NoopCoro = new GlobalVariable(
+        M, NoopCoroConst->getType(), /*isConstant=*/true,
----------------
Looks like unrelated change too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132580/new/

https://reviews.llvm.org/D132580