[PATCH] D132364: [llvm-size] Fix missing file name for darwin output format with non-Mach-O

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

There are several other call sites to `printObjectSectionSizes` in llvm-size. At least one of those (to do with printing archive members) needs updating too (and a corresponding test added). There may be others too, but I think most of the other call sites would result in darwin format printing, since they are for handling Mach-O files or variations thereof. However, you should check.



================
Comment at: llvm/test/tools/llvm-size/elf-m.test:9
 # CHECK:         text    data     bss     dec     hex filename
-# CHECK-NEXT:       0       0       0       0       0
+# CHECK-NEXT:       0       0       0       0       0 [[FILE]]
 
----------------
It might be worth adding `{{$}}` to the end of this line. This will prevent FileCheck from matching successfully, if there's garbage after the filename.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132364/new/

https://reviews.llvm.org/D132364