[PATCH] D132094: [profile] Create only prof header when no counters

Gulfem Savrun Yeniceri via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 25 20:04:46 PDT 2022


gulfem added a comment.

In D132094#3733666 <https://reviews.llvm.org/D132094#3733666>, @ellis wrote:

> When using the `-fprofile-function-groups` option we could hit the case where one of the groups has no profiled functions. In that case it would be more surprising to not find a raw profile, rather than an empty raw profile. If we do go with option 1, maybe we could emit a warning explaining why no profile was emitted. Or if we go with option 2, maybe a warning would also be good to alert the user that it's an empty profile.

What kind of warning do you have in mind @ellis? Are you suggesting to put some text like `Empty Profile` when we read a profile via `llvm-profdata show` (which happens to contain only a header)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132094/new/

https://reviews.llvm.org/D132094



More information about the llvm-commits mailing list