[PATCH] D132696: [ELF] Provide the GNU hash function in libObject

Thu Aug 25 19:50:51 PDT 2022

jhuber6 added a comment.

In D132696#3750807 <https://reviews.llvm.org/D132696#3750807>, @MaskRay wrote:

> This patch may not be needed. You can add it as part of the patch using `hashGnu`. The duplicate in lld/ELF does not matter. When the openmp patches are proven to be mature, we can consider removing duplicate code in lld/ELF.

I was planning on adding `GNU_HASH` support on top of the `HASH` support in the other patch and figured this was an easy part to factor out. I'm not sure what you mean by the OpenMP patches being mature, are you talking about abandoning D131309 <https://reviews.llvm.org/D131309> and just doing it directly inside of the OpenMP runtime and then merging it back into `Elf.h` some other time?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132696/new/

https://reviews.llvm.org/D132696