[PATCH] D131309: [ELF] Add ability to get a symbol by name from the hash table section

Joseph Huber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 25 19:44:57 PDT 2022


jhuber6 added a comment.

In D131309#3750804 <https://reviews.llvm.org/D131309#3750804>, @MaskRay wrote:

> I wish that we don't add unneeded functionality...

It won't be strictly unneeded as the whole point of this was to factor out something done specifically for AMDGPU offloading into a proper ELF helper function. The question then is if we should switch that handling over to use `GNU_HASH` instead. That's a little out of scope of the original patch series I've been trying to land so I was hoping to get this in first and work on that later. We already support other functions using `DT_HASH` in `Object/Elf.h` so I figured it would be fine to support both as many applications provide both as you said.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131309/new/

https://reviews.llvm.org/D131309



More information about the llvm-commits mailing list