[PATCH] D131924: [LAA] Prune dependencies with distance large than access implied by trip count

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/RISCV/safe-dep-distance.ll:13
 ; CHECK-NEXT:  entry:
-; CHECK-NEXT:    br i1 false, label [[SCALAR_PH:%.*]], label [[VECTOR_PH:%.*]]
+; CHECK-NEXT:    [[TMP0:%.*]] = call i64 @llvm.vscale.i64()
+; CHECK-NEXT:    [[MIN_ITERS_CHECK:%.*]] = icmp ult i64 200, [[TMP0]]
----------------
reames wrote:
> fhahn wrote:
> > It might be good to also have a test that just uses `-passes=print-access-info`, but once D132703 goes in this should be covered in general anyways by a dedicated LAA test.
> JFYI, the name of the printer here is non-idiomatic.  I'd tried to find this, and fallen back on the vectorizer test when it didn't come up easily in greps.
> 
> I'd expect this to be: -passes="print<loop-access>" or -passes="print<loop-access-info>".
> 
> But yes, your follow on does add LAA test coverage directly, so we can leave as is.  
Yeah this is something I wanted to change for a bit. I’ll fix that tomorrow


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131924/new/

https://reviews.llvm.org/D131924