[PATCH] D130127: [llvm][TailDuplicator] don't taildup isInlineAsmBrIndirectTargets

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/CodeGen/TailDuplicator.cpp:801
     return false;
+  if (TailBB->isInlineAsmBrIndirectTarget())
+    return false;
----------------
If I'm understanding correctly, the issue here is that PredBB might contain an INLINEASM_BR.  We're checking `TailBB->isInlineAsmBrIndirectTarget` because we don't have any convenient way to check the relevant property of PredBB.  This makes the code in callbr-asm-outputs.ll, but we can't easily avoid it.  Is that correct?

Please add a comment to explain that.  And maybe we should consider adding some more direct way to check if a block contains an INLINEASM_BR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130127/new/

https://reviews.llvm.org/D130127