[PATCH] D131924: [LAA] Prune dependencies with distance large than access implied by trip count

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 25 13:58:50 PDT 2022


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! I was looking into generalizing this a bit further independently to avoid regressions for another patch: D132703 <https://reviews.llvm.org/D132703>. It also covers the change in `safe-dep-distance.ll` but should be good as follow-up.



================
Comment at: llvm/test/Transforms/LoopVectorize/RISCV/safe-dep-distance.ll:13
 ; CHECK-NEXT:  entry:
-; CHECK-NEXT:    br i1 false, label [[SCALAR_PH:%.*]], label [[VECTOR_PH:%.*]]
+; CHECK-NEXT:    [[TMP0:%.*]] = call i64 @llvm.vscale.i64()
+; CHECK-NEXT:    [[MIN_ITERS_CHECK:%.*]] = icmp ult i64 200, [[TMP0]]
----------------
It might be good to also have a test that just uses `-passes=print-access-info`, but once D132703 goes in this should be covered in general anyways by a dedicated LAA test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131924/new/

https://reviews.llvm.org/D131924



More information about the llvm-commits mailing list