[PATCH] D132692: [AMDGPU][MC][GFX11][NFC] Add missing asm tests for VOPCX and VOPCX.DPP instructions

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 25 13:12:11 PDT 2022


dp added a comment.

Thanks for catching the issue. I’ll add separate tests for forced suffix.

Please note that the `_dpp` suffix is only meaningful when there are no modifiers that require `dpp` encoding. I believe all tests in this file have `_dpp8[…]` so adding a `_dpp` suffix does not enforce anything. This was the reason I removed the suffix. We need special tests for this case like the following:

  v_cmpx_u_f32_dpp    v1, v2


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132692/new/

https://reviews.llvm.org/D132692



More information about the llvm-commits mailing list