[PATCH] D128302: [AArch64][CostModel] Detects that {Extract,Insert}Element at lane 0 have the same cost as other lanes for real instructions that operates on integer types

[Mingming Liu via Phabricator via llvm-commits]

mingmingl added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.h:68
+  InstructionCost getVectorInstrCostHelper(Type *Val, unsigned Index,
+                                           bool VirtualInst);
+
----------------
davidxl wrote:
> Maybe changing 'VirtualInst' to be name 'hasNoRealUse' or flip it to 'hasRealUse'?
Change to 'HasRealUse'. An instruction is a derived class of 'User', but I think it's fine to call it a use without ambiguity here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128302/new/

https://reviews.llvm.org/D128302