[PATCH] D130661: RegAllocGreedy: Try local instruction splitting with subranges

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 25 11:28:45 PDT 2022


qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

LGTM with nit.



================
Comment at: llvm/lib/CodeGen/RegAllocGreedy.cpp:1257
+    if (SubReg == 0 && MO.isUse())
+      return MRI.getMaxLaneMaskForVReg(Reg);
+
----------------
I don't think we can early return here.
Technically different operands could be on different register classes and IIRC that may give different `LaneBitmask`s.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130661/new/

https://reviews.llvm.org/D130661



More information about the llvm-commits mailing list