[PATCH] D132036: [llvm-objdump] Add -dyld_info to llvm-otool

Daniel Bertalan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 25 10:22:21 PDT 2022


BertalanD added inline comments.


================
Comment at: llvm/lib/Object/MachOObjectFile.cpp:3390-3392
+  auto Field = [this](uint8_t Right, uint8_t Count) {
+    return (RawValue & ((1ull << Count) - 1) << Right) >> Right;
+  };
----------------
BertalanD wrote:
> reminder to self: simplify this with `maskTrailingOnes`.
nevermind. That wouldn't make the code any clearer.

This weird lambda is needed because bitfields are a pain to work with when endianness is involved.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132036/new/

https://reviews.llvm.org/D132036



More information about the llvm-commits mailing list