[llvm] 5260146 - [InstCombine] restore test for mul+add transform with constant expression; NFC

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 25 08:37:33 PDT 2022


Author: Sanjay Patel
Date: 2022-08-25T11:33:33-04:00
New Revision: 5260146a8a74084f3d38d8bb448ae3c5690b9084

URL: https://github.com/llvm/llvm-project/commit/5260146a8a74084f3d38d8bb448ae3c5690b9084
DIFF: https://github.com/llvm/llvm-project/commit/5260146a8a74084f3d38d8bb448ae3c5690b9084.diff

LOG: [InstCombine] restore test for mul+add transform with constant expression; NFC

This test was added with 6cf6c05322629a17a82aa53e3931086b0,
but then made useless with D4238 / d1bea693e20b470f0.

We still need a test to make sure transforms are not
conflicting when matching a constant expression.

Added: 
    

Modified: 
    llvm/test/Transforms/InstCombine/mul.ll

Removed: 
    llvm/test/Transforms/InstCombine/pr20079.ll


################################################################################
diff  --git a/llvm/test/Transforms/InstCombine/mul.ll b/llvm/test/Transforms/InstCombine/mul.ll
index 71cc1a2a2d5b..c1a8c3113fba 100644
--- a/llvm/test/Transforms/InstCombine/mul.ll
+++ b/llvm/test/Transforms/InstCombine/mul.ll
@@ -611,6 +611,19 @@ define <2 x i64> @test20(<2 x i64> %A) {
   ret <2 x i64> %C
 }
 
+ at g = internal global i32 0, align 4
+
+define i32 @PR20079(i32 %a) {
+; CHECK-LABEL: @PR20079(
+; CHECK-NEXT:    [[ADD:%.*]] = add i32 [[A:%.*]], -1
+; CHECK-NEXT:    [[MUL:%.*]] = mul nsw i32 [[ADD]], ptrtoint (i32* @g to i32)
+; CHECK-NEXT:    ret i32 [[MUL]]
+;
+  %add = add i32 %a, -1
+  %mul = mul nsw i32 %add, ptrtoint (i32* @g to i32)
+  ret i32 %mul
+}
+
 define <2 x i1> @test21(<2 x i1> %A, <2 x i1> %B) {
 ; CHECK-LABEL: @test21(
 ; CHECK-NEXT:    [[C:%.*]] = and <2 x i1> [[A:%.*]], [[B:%.*]]

diff  --git a/llvm/test/Transforms/InstCombine/pr20079.ll b/llvm/test/Transforms/InstCombine/pr20079.ll
deleted file mode 100644
index 3adc20cc33c5..000000000000
--- a/llvm/test/Transforms/InstCombine/pr20079.ll
+++ /dev/null
@@ -1,9 +0,0 @@
-; RUN: opt -S -passes=instcombine < %s | FileCheck %s
- at b = internal global [1 x i32] zeroinitializer, align 4
- at c = internal global i32 0, align 4
-
-; CHECK-LABEL: @fn1
-; CHECK-NEXT: ret i32 0
-define i32 @fn1(i32 %a) {
-  ret i32 0
-}


        


More information about the llvm-commits mailing list