[PATCH] D132664: [debuginfo-tests] Un-XFAIL no passing unused-merged-value.c test

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 25 08:26:49 PDT 2022


Orlando accepted this revision.
Orlando added a comment.
This revision is now accepted and ready to land.

Hi @Michael137. Removing the XFAIL is ok in this case - "optimized out" is preferable to seeing incorrect values and having the test pass now that this is the case is intended. Thanks for checking and updating this!



================
Comment at: cross-project-tests/debuginfo-tests/dexter-tests/memvars/unused-merged-value.c:1
-// XFAIL: *
-// Incorrect location for variable "parama", see PR48719.
+// Location for variable "parama" optimized out
+// Previously it would carry incorrect location
----------------
nit: missing full stop?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132664/new/

https://reviews.llvm.org/D132664



More information about the llvm-commits mailing list