[PATCH] D132664: [debuginfo-tests] Un-XFAIL no passing unused-merged-value.c test

Michael Buch via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 25 08:10:24 PDT 2022


Michael137 created this revision.
Michael137 added reviewers: dblaikie, aprantl, Orlando.
Herald added a project: All.
Michael137 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This test would previously expect one of the parameters to have
an incorrect DW_AT_location. Stepping through `fun` with a debugger
would then no reflect updates to one of the parameters.

With a recent change to Clang's DeadArgumentEliminationPass
(see `879f5118fc74657e4a5c4eff6810098e1eed75ac`) the generated
DWARF does not contain a location for `parama`, and stepping through
the function with `lldb` works as expected.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D132664

Files:
  cross-project-tests/debuginfo-tests/dexter-tests/memvars/unused-merged-value.c


Index: cross-project-tests/debuginfo-tests/dexter-tests/memvars/unused-merged-value.c
===================================================================
--- cross-project-tests/debuginfo-tests/dexter-tests/memvars/unused-merged-value.c
+++ cross-project-tests/debuginfo-tests/dexter-tests/memvars/unused-merged-value.c
@@ -1,5 +1,7 @@
-// XFAIL: *
-// Incorrect location for variable "parama", see PR48719.
+// Location for variable "parama" optimized out
+// Previously it would carry incorrect location
+// information in debug-info, see PR48719.
+// Now, the location is simply not emitted.
 
 // REQUIRES: lldb
 // UNSUPPORTED: system-windows


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132664.455592.patch
Type: text/x-patch
Size: 648 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220825/0d8e32f0/attachment.bin>


More information about the llvm-commits mailing list