[PATCH] D132649: [AMDGPU][MC][GFX11][NFC] Add missing asm tests for VOP1 instructions

Thu Aug 25 07:56:54 PDT 2022

Joe_Nash added a comment.

In D132649#3749019 <https://reviews.llvm.org/D132649#3749019>, @dp wrote:

>> A few things I am noticing: The tests seem to be split into 2 alphabetically sorted chunks. Can we just re-sort the file?
>
> Sure, I'll re-sort the tests. The script appended missing tests to the end of the file which resulted in two sorted chunks.
>
> Do you think we should keep existing tests if they are good enough? Or could we just replace them with generated tests?

It seems like the majority of existing tests were generated by a similar script to what you are using. So if you are replacing them with different registers or something, that's fine the coverage will be similar. If there have been one-off tests added for a particular purpose, I wouldn't want to just wipe those out, but there are a small number (zero?) of those.

>> There appears to be no coverage for VOP1, VOP2, or VOPC promoted to the VOP3 form for the base instructions (we have coverage for vop3 dpp). Do you plan to cover that?
>
> Yes, I noticed that. We also have very little coverage for VOPC.DPP, VOPCX.DPP and VOPD. I'm currently analyzing test coverage and will add missing tests for all encodings.

Great, thanks!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132649/new/

https://reviews.llvm.org/D132649