[PATCH] D132649: [AMDGPU][MC][GFX11][NFC] Add missing asm tests for VOP1 instructions

Joe Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 25 06:48:33 PDT 2022


Joe_Nash added a comment.

The added coverage is good, thanks.
A few things I am noticing: The tests seem to be split into 2 alphabetically sorted chunks. Can we just re-sort the file? 
There appears to be no coverage for VOP1, VOP2, or VOPC promoted to the VOP3 form for the base instructions (we have coverage for vop3 dpp). Do you plan to cover that?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132649/new/

https://reviews.llvm.org/D132649



More information about the llvm-commits mailing list