[PATCH] D132508: [MC] Omit fill value if it's zero when emitting code alignment

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 25 00:03:16 PDT 2022


MaskRay accepted this revision.
MaskRay added a comment.

LGTM.



================
Comment at: llvm/test/CodeGen/AArch64/p2align-zero-fillvalue.ll:1
+; RUN: llc -mtriple=aarch64-none-linux-gnu < %s -o - | FileCheck %s
+
----------------
Use `aarch64` to test generic ELF behavior, not just linux-gnu.


================
Comment at: llvm/test/CodeGen/AArch64/p2align-zero-fillvalue.ll:8
+; CHECK-NEXT: .globl foo
+; CHECK-NEXT: .p2align 2, 0x0
----------------
Add trailing `{{$}}`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132508/new/

https://reviews.llvm.org/D132508



More information about the llvm-commits mailing list